From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752039AbcGXHXs (ORCPT <rfc822;w@1wt.eu>);
	Sun, 24 Jul 2016 03:23:48 -0400
Received: from mga14.intel.com ([192.55.52.115]:7921 "EHLO mga14.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751543AbcGXHXq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 24 Jul 2016 03:23:46 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,412,1464678000"; 
   d="scan'208";a="1001354279"
Date: Sun, 24 Jul 2016 13:01:09 +0530
From: Vinod Koul <vinod.koul@intel.com>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>, Andy Green <andy.green@linaro.org>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        Jingoo Han <jg1.han@samsung.com>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Mark Brown <broonie@kernel.org>, Andy Green <andy@warmcat.com>
Subject: Re: [PATCH 4/7] k3dma: Add cyclic mode for audio
Message-ID: <20160724073108.GD9681@localhost>
References: <1469073189-9167-1-git-send-email-john.stultz@linaro.org>
 <1469073189-9167-5-git-send-email-john.stultz@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1469073189-9167-5-git-send-email-john.stultz@linaro.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 20, 2016 at 08:53:06PM -0700, John Stultz wrote:

>  	ds = kzalloc(sizeof(*ds) + num * sizeof(ds->desc_hw[0]), GFP_ATOMIC);
> -	if (!ds) {
> -		dev_dbg(chan->device->dev, "vchan %p: kzalloc fail\n", &c->vc);
> +	if (!ds)

This is an unrelated change

> +
> +	ds = kzalloc(sizeof(*ds) + num * sizeof(ds->desc_hw[0]), GFP_ATOMIC);

we should use GFP_NOWAIT. And looks like driver doesn't use GFP_NOWAIT< so
you may fix that up as well

> +	if (!ds)
> +		return NULL;
> +
> +	ds->desc_hw_lli = __virt_to_phys((unsigned long)&ds->desc_hw[0]);

why no dma_map_single(()?

Also __api is internal APIs, driver should not use them. Why not plain
virt_to_phys()

-- 
~Vinod