* [PATCH 31/32] staging: android: ion: ion.c fixed a 80 character line limit coding style issue
@ 2016-07-24 7:37 Nadim almas
2016-07-24 20:44 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Nadim almas @ 2016-07-24 7:37 UTC (permalink / raw)
To: sumit.semwal; +Cc: devel, linux-kernel, sarique, Nadim almas
From: sarique <nadim.902@gmail.com>
fixed a coding style issue.
Signed-off-by: Nadim almas <nadim.902@gmail.com.com>
---
drivers/staging/android/ion/ion.c | 3 ++-
drivers/staging/comedi/drivers/ssv_dnp.c | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index a2cf93b..52345df 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -1358,7 +1358,8 @@ static long ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
struct ion_handle *handle;
mutex_lock(&client->lock);
- handle = ion_handle_get_by_id_nolock(client, data.handle.handle);
+ handle = ion_handle_get_by_id_nolock(client,
+data.handle.handle);
if (IS_ERR(handle)) {
mutex_unlock(&client->lock);
return PTR_ERR(handle);
diff --git a/drivers/staging/comedi/drivers/ssv_dnp.c b/drivers/staging/comedi/drivers/ssv_dnp.c
index f9f634f..5674427 100644
--- a/drivers/staging/comedi/drivers/ssv_dnp.c
+++ b/drivers/staging/comedi/drivers/ssv_dnp.c
@@ -121,9 +121,9 @@ static int dnp_dio_insn_config(struct comedi_device *dev,
}
val = inb(CSCDR);
- if (data[0] == COMEDI_OUTPUT)
+ if (data[0] == COMEDI_OUTPUT)
val |= mask;
- else
+ else
val &= ~mask;
outb(val, CSCDR);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 31/32] staging: android: ion: ion.c fixed a 80 character line limit coding style issue
2016-07-24 7:37 [PATCH 31/32] staging: android: ion: ion.c fixed a 80 character line limit coding style issue Nadim almas
@ 2016-07-24 20:44 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2016-07-24 20:44 UTC (permalink / raw)
To: Nadim almas; +Cc: sumit.semwal, devel, Nadim almas, linux-kernel
On Sun, Jul 24, 2016 at 12:37:31AM -0700, Nadim almas wrote:
> From: sarique <nadim.902@gmail.com>
>
> fixed a coding style issue.
What issue?
>
> Signed-off-by: Nadim almas <nadim.902@gmail.com.com>
Your From: and signed-off-by names do not match up :(
And where are the other 31 patches in this series?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-24 20:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-24 7:37 [PATCH 31/32] staging: android: ion: ion.c fixed a 80 character line limit coding style issue Nadim almas
2016-07-24 20:44 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox