From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752640AbcGYHcS (ORCPT ); Mon, 25 Jul 2016 03:32:18 -0400 Received: from down.free-electrons.com ([37.187.137.238]:53866 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752569AbcGYHcI (ORCPT ); Mon, 25 Jul 2016 03:32:08 -0400 Date: Mon, 25 Jul 2016 09:32:04 +0200 From: Maxime Ripard To: Michal Suchanek Cc: linux-sunxi , stable@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Chen-Yu Tsai , Russell King , Mark Brown , Arnd Bergmann , Olof Johansson , Krzysztof Kozlowski , Javier Martinez Canillas , Simon Horman , Sjoerd Simons , Thierry Reding , Alison Wang , Timo Sigurdsson , Jonathan Liu , Gerhard Bertelsmann , Priit Laes , devicetree , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List , linux-spi Subject: Re: [PATCH v3 00/13] sunxi spi fixes Message-ID: <20160725073204.GD7419@lukather> References: <20160613195716.GD9354@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="11Y7aswkeuHtSBEs" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --11Y7aswkeuHtSBEs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 17, 2016 at 12:34:44PM +0200, Michal Suchanek wrote: > Hello, >=20 > On 13 June 2016 at 21:57, Maxime Ripard > wrote: > > On Mon, Jun 13, 2016 at 05:46:48PM -0000, Michal Suchanek wrote: > >> Hello, > >> > >> This is update of the sunxi spi patches that should give full-featured= SPI > >> driver. > >> > >> First three patches fix issues with the current driver and can be of u= se for > >> stable kernels so adding cc for those. > >> > >> I merged the sun4i and sun6i driver because there several issues that = need to > >> be fixed in both separately and they are even out of sync wrt some fix= es. > >> I guess some of the merge patches can be squashed. > >> > >> I tested this with A10s Olinuxino Micro. I have no sun6i device so I c= annot > >> tell if that side was broken by this patchset - especially the last pa= tch that > >> adds DMA was afaik never tested on sun6i. > > > > > > For the record, I'm still very much opposed to such a merge. >=20 > What is the reason against the merge? I did not find the original > discussion. I really prefer some code that is concise and clear but a little duplicated over some code that shares every possible lines of code but is a giant mess impossible to understand. I just came across the reg_field stuff in regmap that would allow to partially address that problem though, there's still the bit indices issue to overcome though. > I tried to rename everything in the drivers from sun4i and sun6i to > sunxi to look at a clean diff and found about 5 differences 2 of which > look like a bug. It's hard to tell without testing. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --11Y7aswkeuHtSBEs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXlcB0AAoJEBx+YmzsjxAgtJsP/AtAViSbvS6wRju9JC9gJHJj El8iXqP6w1A2S2e+sXSV17Np5n5LdIZpcRpRQSrs9hOrH+D2UZFpdtGmFpzbjWO6 JI8KEVe1SoISL4FOtwX/VLiyrzrb6QdfwuQ4tJxweolxT4JFoEk0uv3UnAa9lq1B zJytqUKg0qpvqPnBXbpPWPbggW2LOdzy1vWp2NjkCQHhViBpbqhl0eAnLatQzChR 01qJKu+QUyuyUVdrsbJW3tTTQJuWAAj+t/Z4QpM1a9bdkgESuALYT3SWjFdSE88A iybEjFuGs583slDVXiCA/Kyw0IxyJz/98x9gWRyimTjhatQBbez7hUk3xqhFdI1J ao1D7u2yO3ytKnis0m45pTjDILhB1Q6DtIatvFVPm4UMzdvtXaXvjBh06p9OY26k UQUyDi2htC8KEUvrp310/+sZHI/feF3dz1nKe7GpZeCH3akauIlJ3ZSytZ9hBEhx SB1sDJiKMYhtIGozGSS+WwlPK/af362LnYiV78W1RJ6rVJEUHrCC4sMJZq04ims/ OSa1zNX9Z89hiOVxYC9NQIaYy0w6M92jA5lkieGcY/tm0eef2MODNWANJnj4AY0w ib0cmsw6kEFsV08ujnviIo1lQYtuVRkMiJyyyQdbHRCVlIiEnogJRnNKp3rxf2AF htSVkqpiij4/L5NKV+kg =coAE -----END PGP SIGNATURE----- --11Y7aswkeuHtSBEs--