From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751743AbcGYKjS (ORCPT ); Mon, 25 Jul 2016 06:39:18 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:37249 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751015AbcGYKjG (ORCPT ); Mon, 25 Jul 2016 06:39:06 -0400 Date: Mon, 25 Jul 2016 11:40:15 +0100 From: Lee Jones To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, seanpaul@chromium.org, benjamin.gaignard@linaro.org Subject: Re: [STLinux Kernel] [PATCH 1/1] drm/sti: use new Reset API Message-ID: <20160725104015.GK14925@dell> References: <20160725100933.9261-1-lee.jones@linaro.org> <20160725103232.GA4278@griffinp-ThinkPad-X1-Carbon-2nd> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160725103232.GA4278@griffinp-ThinkPad-X1-Carbon-2nd> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Jul 2016, Peter Griffin wrote: > On Mon, 25 Jul 2016, Lee Jones wrote: > > > Since 0b52297f228 ("reset: Add support for shared reset controls") the > > new Reset API now demands consumers choose either an *_exclusive or a > > *_shared line when requesting reset lines. > > > > This issue was found when running a kernel containing the aforementioned > > patch which includes an informitive WARN(). It implies that one or > > more used reset lines are in fact shared. This is why we're using the > > *_shared variant. > > > > Signed-off-by: Lee Jones > > --- > > drivers/gpu/drm/sti/sti_compositor.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Your missing a changelog on the v2 version. This isn't really a v2, hence the lack if [PATCH vX] increment. This is v1 with a more verbose changelog. > Apart from that: > Acked-by: Peter Griffin Ta. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog