From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752023AbcGYLo7 (ORCPT ); Mon, 25 Jul 2016 07:44:59 -0400 Received: from mail-bl2nam02on0049.outbound.protection.outlook.com ([104.47.38.49]:29876 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751252AbcGYLoy (ORCPT ); Mon, 25 Jul 2016 07:44:54 -0400 X-Greylist: delayed 422 seconds by postgrey-1.27 at vger.kernel.org; Mon, 25 Jul 2016 07:44:53 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jan.Glauber@cavium.com; Date: Mon, 25 Jul 2016 13:32:41 +0200 From: Jan Glauber To: Paul Gortmaker CC: Mark Brown , LKML , , "Steven J. Hill" , "David Daney" Subject: Re: [PATCH 5/6] spi: octeon: Split driver into Octeon specific and common parts Message-ID: <20160725113241.GA2849@hardcore> References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [94.218.231.148] X-ClientProxiedBy: AMSPR04CA0054.eurprd04.prod.outlook.com (10.242.87.172) To CY1PR07MB2587.namprd07.prod.outlook.com (10.167.16.137) X-MS-Office365-Filtering-Correlation-Id: 6653aa3b-ff9b-4ba4-7bf2-08d3b47f6b70 X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2587;2:TLUzdwFXeXZ9eobnuZvOPXWnT3mUES2Qc3a38xdrlSBVQ4O/3WV5oeSwO/T5uZS7sZ9mHZNeFM0ZxAFEEe3P0ON1APLJBONfrbGyR3cSz1OxlP6/d6X+KiNp2TBd23PlzBN8+c0KFQsGonHxqs1kmHFBmekmg1pz4D/gcVPnMjVHgJnkD/u9Fj+W24OZpudk;3:O04MRWgUMD9JFbonKr++LyPUTnEU35zoD2oTFIdhGp9//aBb0diu9meYgrVp5l32/KMrqzd8S706LnAjKuhtBEknQPy5feVtj1nXVXCYDpAXN3q7lDvsQXk3X2ZzHOvb X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2587; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2587;25:QD62BvaRj+pv9ZZ0JJ5lKoGwySKEX0BbQ6f6XHD6JgqqvgqteBYe9agew9NsiAGSBGfl9HWh8SQoPFEADxkGIpVPJS/AnN6UIE+bxEJvwnl4y8wNZuYxfplbsWvQyeRc/vRDmXMvuQHTaW/7PcaS4VtA9feBIHZ4illQTtjwB+hRDgiAc12NeQy2y63ZBgLsFVnCSJhHErEoxHkDIO6kRXoTbl6AdWt2h7cglr9Abpjv4vIeH0AxPT3xKC+CmQuhtQVhP+KZlWiHMu/C9ND0mPQ4egOi784HnoO9joShjLZkGqOkTw7k9bhgr13EUseQuLTSWgXKTD46mXdxvaGirTSdWOgyWWOOobiqwSvfZcjgNRtXvAv7umGFsn494bFdYRufY3Po813ZsLy5hw1ftIHp9281CtVMdn+JoHpWVR3tIzBggxAd6Qz2pw5IwDPl/WJA5Fze31Puftzf4AbPkRAHLP7Hi4XglMLGAaciw+QmZ/0DCwNsAb+AN6dPtoGLsx4GotgYZ6fKn68YMQEyjiRTx7p4hk+h8gjQAyHyCMyYbsnhLecafdcf0TcUFWQatbMmSXzAlvuA1+Qi6zd1BE3F3XDP2cN3yzUkUM9XpSPl0cVHY/PUuEhMH1gZ85kG/O2ziVMgj1kv5K1Ca+nOxb3mfD8t5j47oc6W+VwIO/+xga9taO3LsUnMRyOs5lulDrMm6mv9H6TykyX0uOd843cotOj3EqiCgD+GtZMVXXRfV8urnP0NoszRYJLrrTQq X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2587;31:r/J1VPByLJdTIN0WKS0nlKYqrLD5Ngkn4ycBGd7HCFzwSUfOCS4zRuKsbfAUMLiCKHgnyWFpqvYdBGPWvpZJZXjt+I4J4UrdHwQHqf2mYG3IMGurFPbNQiwwk4WInOAKZAT2uLHsyGcDihQCBUgw3gMZh9ITabendts0AoojV3ydKD+5Q+g0tXSHVkQh1Zp1r/21xpCPjWr2qWd7WLZpgg==;20:FGS7zVoKyjteSJ+1Bvg98RkeagarxEfHC72JwbdjC9xpubGpk0tNfbldSHn1wV6J/KzVzkBam2HbpoUNgFvf7DsUHZoJU+m+BTtaEqwYSAPHVJjjkXrvGcA5mABME98mGvRQFQGaHKrS3x4RCng9A7cztn0dnmqBWgN1P/nY28Ejgpi2IJSvPPk6Yr8xKhgdcEvQkHj5INKUQ6L3Nr3+jUGy449YGUMpQPROAl147JFVtwVXlk9r+KtoaA1XL5l4iM0UMqompKSYjQ6F+yyePhCu23Aa7P9biNDC7RqhEsgFgfkhmX+JBA3kjIpgQxbE+Rqt4JSANW483BOZZpGKKiJDf9zoyIvlF02PzApf4h7SQ3s1tMRvpQSZlUMV+1cEJAtB0esMYBvohHRXSEupudqcW++cpxray2e0muLQcqh9j7e9y9tBgtCJ7zAvMa3RtuZkPZttHfCjPM41DMhC+n+up+IZC0SNoC9Oe91gmHp0foTAxXydFGPa2KJnW6Jzyyx97ObSY9J/nOsy1pWhFMiQx+CvkwmE2jUHcEzyzjP40m9GPWEQLcXkB9PNX2KlRD3EiHRgz4qFQba6CPHDzLRdBwkPncHTeaT2WZ+uhxk= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:CY1PR07MB2587;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2587; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2587;4:IG//9Qqj43LPe9kToB1G0RAA64cbovcbF9leyskGpIvomCJXJgTBWRi/SteEku/oo6DF96lG0UDWNVwNFJPXCW9HivqBruQmYP8SdtpGxjTXCDe/vE9SYRrGgcLYKIdM4/XNtULuf/qWn83yC1EC3FAI8pXHTcKM/xEBuWpQydhoe3jDCkvjoOLsOd3yKapo2LjfdNuElJ2gWmm2V4isecuhOBw6GUgYyZ9p3svkAA0hPXzdwzMRBWEzjxIhcq+PY4XS28sj3Q4s4kg6Pkq2LBpe3M98uN96CXOmoSssak3FIufB9dln+I2IoV9ZIjl+R82+F1G4At98a/1sZx003Eq7TgH/kHRRL0xzCyR0FfsyhqScDoejHhTYiqo2WUVv X-Forefront-PRVS: 0014E2CF50 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(24454002)(377454003)(199003)(189002)(77096005)(66066001)(4001430100002)(97756001)(92566002)(2950100001)(1076002)(50466002)(19580405001)(33716001)(19580395003)(105586002)(81156014)(110136002)(23726003)(8676002)(81166006)(3846002)(189998001)(586003)(47776003)(97736004)(107886002)(6116002)(2906002)(4001350100001)(68736007)(7846002)(7736002)(50986999)(305945005)(9686002)(83506001)(46406003)(54356999)(76176999)(42186005)(4326007)(101416001)(33656002)(106356001)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR07MB2587;H:hardcore;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR07MB2587;23:3+yKeUKiYDoB8dQvlPLUdFnk9khFaFyy2pxmbrXcZ?= =?us-ascii?Q?lhzb5q7tuD5SivpbTZ19qOY5YO35eX5/ZQE4Z59tACrI8mim41gxAH7jjjEP?= =?us-ascii?Q?w6RIzILEKFDAePHFKPPq5QeaXpsT5Izwks+ILuJkv/IAOahSa0nhoGfuoOyh?= =?us-ascii?Q?Yy4JVVk3iLcQ3VWHf1I2t5VvAR3eHQGrArHitHihyElnaEYyFatbvsTaDhal?= =?us-ascii?Q?pZBKX0MVrXr/uJNZfA8lnEMvPp0d9pd17ASig4kSkY/wu8Ya9CsVk5/m0Xdf?= =?us-ascii?Q?0oMbaSFBIU4PEobnid4keMVCpAPbx8Y5o7sEkR7RE+sznRIzHYx7xeHHvpaa?= =?us-ascii?Q?is83UKyFcf/6zTlvwj+Yx+I/1HJomYqDzHrBa6Kzhxb0Z858prRM3I/MX9BF?= =?us-ascii?Q?a7s/crMc4Q2fnIXLO9hnaMyW1DzKQDL8AX+0Q1nmxekOsDzGfb+AjuSlB8B1?= =?us-ascii?Q?94WjKLPLcq+gbsURq4fYPuhX/iyEHlmIXgHDpJBeFdHD+s1zBYL1heNhWFXH?= =?us-ascii?Q?/vHyc3XD6MxdTMJDih+9H2uv9qPzKUoVhYlRlmzPXn4AAbed9Mom393OsvRI?= =?us-ascii?Q?uZcQYl4YNoE3Q9ktT1tqdLefLvQOH/DhxnjWKQR0dSF1t/YpNF9WfRl4Im15?= =?us-ascii?Q?Ef+oBZ6Bcmpr74ZY0ceE4xtJ8wCcUOTIE+2h9RbpkjpeuBo08qsomU7M+XWB?= =?us-ascii?Q?Y5FPmdJqNk36Jn0XrBZnQtaCuzifEU6XnKXjQ7lWWkNzJ8yS2eVmWYwwhxrW?= =?us-ascii?Q?L7L+sgb87ALlt+xvJNpU8N+9vahTGxz3yiH38KFnupOeqxBUGx4E73eeAE6f?= =?us-ascii?Q?4VW1kYsJXWRDaKtdb0sjVXgUvEHFgWU7VBAV1u6gfsbINnnHNn9k+uoygWay?= =?us-ascii?Q?ZUU2u2n0+KKW9UnRvuqat1ZRmBsfLw+fYKdqoy26qbnsSNYdiTuSEuZFNYpG?= =?us-ascii?Q?oNlIgSbakx56idM1zPZva4VsZX4Kfj/Jwh7o0JRt56MF443xWkVOGcvP+nUj?= =?us-ascii?Q?NqZA5aSgVbEgdCT+q92vJp8JgHYSiITgqRBFCaLMAmh3xFJ/4UAQE9gb1gn0?= =?us-ascii?Q?ADIvuWm6QLHz9yk4kBFoufs/eQMIz3Aqj5tci0fSkdTC9gKRPbhrWbVvK7Nv?= =?us-ascii?Q?V41zMwkbrnji8zLgzi9jKT80SguKWR/cKnHC0bEyAwpbyHCiycCFpzr8i90Y?= =?us-ascii?Q?AXyXME4BwlXhyp+DieT/DBCI5vJ/BOZzdkKJm4MOBv1wnwPaQyPLoZjIA=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2587;6:OJy/xlDTLe7MtFBCrNA474cJ5wRm6SxvpBBw9DFfxmtjnnSjmZHzvin5UwVwo2guEXwdP1M7W66pGUVM+4WiJX7HLldS08AzIunEihEtqRiNGGlmV9NlQOCE2IvLB7GAHMqvGV6N3wCFGQXzjLz6iKm5ADvE67mjg99dJUxtvnV5rxuDxedMQ8XDrrcti8mdrqpqU69WTmY46r3ZuI30+18iQt2OxPgxi6mxV2Fvqq7IyX0Irzs820PccWLvfYh6xOL/Cd7dCxx0gh3OsbpkXpBLt498DX1P5M3BMPoiz6A=;5:QqVv+F4eVEuweZC6g9q/Il5JGmOkRWIqf32WBUHgEkCEHtgGfSYc5a7Qpg2l6CYyZo5UMC6IEh6hTvuUexI5jj3B6vL7IHBksB/8IjYqXARJ6vf/UTdN1Q4dUYjSp0NXhTDz2dAgS7c6yl86Dzrx6Q==;24:o0Bq/4pRlI+G3FAnZr5vVqtE8yzA5HurLVq95v68F+Z8ENC6xb7iv7dWPwx1bd/mSfHU32EEbQOu96D+3ENX2Tr92X6mK6n1Q/HQn9xGYRU=;7:hr+bARYX++HeWyjEYxXD5GrdylzCHM1+LfhixUhZVEYcZUlAtCRgaGTXvE1vVSDzp7xLdQhzTPQ6m1E16tsxkG1Aqi/jv6YOsBq3/06U0+72cVCCUIiEzGMRt/z7iWFjNZWOgBcM4qgBToo9Rc8PtLB9mKJY7B1AHMg6bTCKsy7YzpwsABqvf28GFct5QtpCvoo77/Hw09L7OBSMa+71NNQpG7WQo+oHllF6M8zVXpYtGlbP9tHW6yg35ABde2+O SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2016 11:32:53.0819 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2587 X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2587;23:nSGt1QRz7ixfy6/49YRFPh1YfmdQHED6ZgzU6LmtQu4sFzJoorqjEgCJVqq4E2TYRFgsNB59vmhDX4OgqZio8moOFypB0vSRAB1RBKmCmRXGCPkXBbbRGN1jxq1oqUZOB/mGkP51GUSDq8JnX1JxZx/QmmJwjlVJ0Kr5MREJsFsXZP7SDaOJQqbQ7Xm1SnTw X-OriginatorOrg: caviumnetworks.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 24, 2016 at 02:38:11PM -0400, Paul Gortmaker wrote: > On Sat, Jul 23, 2016 at 6:42 AM, Jan Glauber wrote: > > Separate driver probing from SPI transfer functions. > > > > Signed-off-by: Jan Glauber > > Tested-by: Steven J. Hill > > --- > > drivers/spi/Makefile | 1 + > > drivers/spi/spi-cavium-octeon.c | 104 +++++++++++++++++++++++++ > > drivers/spi/{spi-octeon.c => spi-cavium.c} | 120 +---------------------------- > > drivers/spi/spi-cavium.h | 31 ++++++++ > > 4 files changed, 138 insertions(+), 118 deletions(-) > > create mode 100644 drivers/spi/spi-cavium-octeon.c > > rename drivers/spi/{spi-octeon.c => spi-cavium.c} (55%) > > > > diff --git a/drivers/spi/Makefile b/drivers/spi/Makefile > > index 3c74d00..185367e 100644 > > --- a/drivers/spi/Makefile > > +++ b/drivers/spi/Makefile > > @@ -56,6 +56,7 @@ obj-$(CONFIG_SPI_MT65XX) += spi-mt65xx.o > > obj-$(CONFIG_SPI_MXS) += spi-mxs.o > > obj-$(CONFIG_SPI_NUC900) += spi-nuc900.o > > obj-$(CONFIG_SPI_OC_TINY) += spi-oc-tiny.o > > +spi-octeon-objs := spi-cavium.o spi-cavium-octeon.o > > obj-$(CONFIG_SPI_OCTEON) += spi-octeon.o > > obj-$(CONFIG_SPI_OMAP_UWIRE) += spi-omap-uwire.o > > obj-$(CONFIG_SPI_OMAP_100K) += spi-omap-100k.o > > diff --git a/drivers/spi/spi-cavium-octeon.c b/drivers/spi/spi-cavium-octeon.c > > new file mode 100644 > > index 0000000..ee4703e > > --- /dev/null > > +++ b/drivers/spi/spi-cavium-octeon.c > > @@ -0,0 +1,104 @@ > > +/* > > + * This file is subject to the terms and conditions of the GNU General Public > > + * License. See the file "COPYING" in the main directory of this archive > > + * for more details. > > + * > > + * Copyright (C) 2011, 2012 Cavium, Inc. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > [...] > > > +MODULE_DEVICE_TABLE(of, octeon_spi_match); > > + > > +static struct platform_driver octeon_spi_driver = { > > + .driver = { > > + .name = "spi-octeon", > > + .of_match_table = octeon_spi_match, > > + }, > > + .probe = octeon > _spi_probe, > > + .remove = octeon_spi_remove, > > +}; > > + > > +module_platform_driver(octeon_spi_driver); > > + > > +MODULE_DESCRIPTION("Cavium, Inc. OCTEON SPI bus driver"); > > +MODULE_AUTHOR("David Daney"); > > +MODULE_LICENSE("GPL"); > > diff --git a/drivers/spi/spi-octeon.c b/drivers/spi/spi-cavium.c > > similarity index 55% > > rename from drivers/spi/spi-octeon.c > > rename to drivers/spi/spi-cavium.c > > index 2180176..5aaf215 100644 > > --- a/drivers/spi/spi-octeon.c > > +++ b/drivers/spi/spi-cavium.c > > @@ -6,42 +6,13 @@ > > * Copyright (C) 2011, 2012 Cavium, Inc. > > */ > > > > -#include > > -#include > > #include > > #include > > It almost looks like all the modular stuff got moved to the new file and > maybe the above module.h isn't needed in the original file anymore? > > Paul. > -- Yes, that can be removed. Also io.h isn't needed there. thanks, Jan > > #include > > #include > > -#include > > - > > -#include > > > > #include "spi-cavium.h" > > [...]