From: Mark Brown <broonie@kernel.org>
To: Jan Glauber <jan.glauber@caviumnetworks.com>
Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
"Steven J. Hill" <steven.hill@cavium.com>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH 6/6] spi: octeon: Add thunderx driver
Date: Mon, 25 Jul 2016 17:20:01 +0100 [thread overview]
Message-ID: <20160725162001.GE11806@sirena.org.uk> (raw)
In-Reply-To: <20160725155122.GA2710@hardcore>
[-- Attachment #1: Type: text/plain, Size: 768 bytes --]
On Mon, Jul 25, 2016 at 05:51:22PM +0200, Jan Glauber wrote:
> On Sun, Jul 24, 2016 at 10:04:52PM +0100, Mark Brown wrote:
> > On Sat, Jul 23, 2016 at 12:42:55PM +0200, Jan Glauber wrote:
> > > +#define PCI_DEVICE_ID_THUNDERX_SPI 0xa00b
> > > +static const struct pci_device_id thunderx_spi_pci_id_table[] = {
> > > + { PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, PCI_DEVICE_ID_THUNDERX_SPI) },
> > > + { 0, }
> > > +};
> > The define for the device ID doesn't seem to be adding much here.
> I find it more readable instead of PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, 0xa00b),
> or did I miss your point?
No, that's my point - I find myself wondering why there's a define half
way down the file and what else is looking at the define other than the
location a few lines below.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-07-25 16:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-23 10:42 [PATCH 0/6] SPI ThunderX driver Jan Glauber
2016-07-23 10:42 ` [PATCH 1/6] spi: octeon: Convert driver to use readq()/writeq() functions Jan Glauber
2016-07-23 10:42 ` [PATCH 2/6] spi: octeon: Store system clock freqency in struct octeon_spi Jan Glauber
2016-07-23 10:42 ` [PATCH 3/6] spi: octeon: Put register offsets into a struct Jan Glauber
2016-07-23 10:42 ` [PATCH 4/6] spi: octeon: Move include file from arch/mips to drivers/spi Jan Glauber
2016-07-23 10:42 ` [PATCH 5/6] spi: octeon: Split driver into Octeon specific and common parts Jan Glauber
2016-07-24 18:38 ` Paul Gortmaker
2016-07-25 11:32 ` Jan Glauber
2016-07-24 20:54 ` Mark Brown
2016-07-25 11:37 ` Jan Glauber
2016-07-25 17:49 ` [PATCH v2] " Jan Glauber
2016-07-23 10:42 ` [PATCH 6/6] spi: octeon: Add thunderx driver Jan Glauber
2016-07-24 21:04 ` Mark Brown
2016-07-25 15:51 ` Jan Glauber
2016-07-25 16:16 ` Mark Brown
2016-07-25 16:31 ` David Daney
2016-07-25 17:56 ` [PATCH v2] " Jan Glauber
2016-07-27 18:08 ` Mark Brown
2016-07-28 8:12 ` Jan Glauber
2016-07-28 13:58 ` Mark Brown
2016-07-27 18:12 ` [PATCH 6/6] " Mark Brown
2016-07-27 18:25 ` David Daney
2016-07-27 19:08 ` Mark Brown
2016-07-25 16:20 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725162001.GE11806@sirena.org.uk \
--to=broonie@kernel.org \
--cc=david.daney@cavium.com \
--cc=jan.glauber@caviumnetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=steven.hill@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox