From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753468AbcGYQpQ (ORCPT ); Mon, 25 Jul 2016 12:45:16 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40461 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752463AbcGYQpO (ORCPT ); Mon, 25 Jul 2016 12:45:14 -0400 Date: Mon, 25 Jul 2016 09:45:29 -0700 From: Greg Kroah-Hartman To: Sergei Shtylyov Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] platform: don't return 0 from platform_get_irq[_byname]() on error Message-ID: <20160725164529.GA7540@kroah.com> References: <5153966.D0zlDt82d1@wasted.cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 25, 2016 at 02:55:37PM +0300, Sergei Shtylyov wrote: > Hello. > > On 7/4/2016 1:04 AM, Sergei Shtylyov wrote: > > > of_irq_get[_byname]() return 0 iff irq_create_of_mapping() call fails. > > Returning both error code and 0 on failure is a sign of a misdesigned API, > > it makes the failure check unnecessarily complex and error prone. We should > > rely on the platform IRQ resource in this case, not return 0, especially > > as 0 can be a valid IRQ resource too... > > > > Fixes: aff008ad813c ("platform_get_irq: Revert to platform_get_resource if of_irq_get fails") > > Signed-off-by: Sergei Shtylyov > > CC: stable@vger.kernel.org > > 4.7 has been tagged now. Can I count on this patch getting to 4.8? Or at > least some feedback given? :-/ I'll get to it after 4.8-rc1 is out, but ideally one of the of developers would look at it, as I have no way to test this... thanks, greg k-h