[PATCH 4.6 184/203] ovl: fix dentry leak for default_permissions

Greg Kroah-Hartman
2016-07-25T21:50:56Z

From: Miklos Szeredi <mszeredi@redhat.com>

commit a4859d75944a726533ab86d24bb5ffd1b2b7d6cc upstream.

When using the 'default_permissions' mount option, ovl_permission() on
non-directories was missing a dput(alias), resulting in "BUG Dentry still
in use".

Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Fixes: 8d3095f4ad47 ("ovl: default permissions")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
fs/overlayfs/inode.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

--- a/fs/overlayfs/inode.c
+++ b/fs/overlayfs/inode.c
@@ -121,16 +121,18 @@ int ovl_permission(struct inode *inode,

err = vfs_getattr(&realpath, &stat);
if (err)
- return err;
+ goto out_dput;

+ err = -ESTALE;
if ((stat.mode ^ inode->i_mode) & S_IFMT)
- return -ESTALE;
+ goto out_dput;

inode->i_mode = stat.mode;
inode->i_uid = stat.uid;
inode->i_gid = stat.gid;

- return generic_permission(inode, mask);
+ err = generic_permission(inode, mask);
+ goto out_dput;
}

/* Careful in RCU walk mode */