From: Johannes Weiner <hannes@cmpxchg.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] mm: Drop unnecessary include file
Date: Mon, 25 Jul 2016 16:35:44 -0400 [thread overview]
Message-ID: <20160725203544.GA14491@cmpxchg.org> (raw)
In-Reply-To: <1469339408-9240-1-git-send-email-linux@roeck-us.net>
On Sat, Jul 23, 2016 at 10:50:08PM -0700, Guenter Roeck wrote:
> Commmit e9be930fa6b5 ("mm: fix vm-scalability regression in cgroup-aware
> workingset code") adds '#include <linux/mm.h>' to
> include/linux/memcontrol.h. This results in the following build error
> when building hexagon images.
>
> In file included from ./include/linux/memcontrol.h:32:0,
> from ./include/linux/swap.h:8,
> from ./arch/hexagon/include/asm/pgtable.h:27,
> from mm/init-mm.c:9:
> ./include/linux/mm.h:322:2: error: unknown type name 'pmd_t'
> ./include/linux/mm.h:353:7: error: unknown type name 'pmd_t'
> ./include/linux/mm.h:414:30: error: unknown type name 'pmd_t'
>
> The include file does not appear to be necessary, so just drop it.
>
> Fixes: e9be930fa6b5 ("mm: fix vm-scalability regression in cgroup-aware workingset code")
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
It was needed because mem_cgroup_zone_zoneinfo() used zone_to_nid().
Mel's nodelru patches have since renamed it to mem_cgroup_nodeinfo()
and dropped the zone_to_nid() reference, that's why it's no longer
necessary.
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
[ I'd put it in after the nodelru patches, though, to maintain
bisectability on x86 over hexagon. ]
prev parent reply other threads:[~2016-07-25 20:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-24 5:50 [PATCH -next] mm: Drop unnecessary include file Guenter Roeck
2016-07-25 8:02 ` Michal Hocko
2016-07-25 20:35 ` Johannes Weiner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725203544.GA14491@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox