From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753301AbcGYUi3 (ORCPT ); Mon, 25 Jul 2016 16:38:29 -0400 Received: from gum.cmpxchg.org ([85.214.110.215]:54550 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753180AbcGYUi1 (ORCPT ); Mon, 25 Jul 2016 16:38:27 -0400 Date: Mon, 25 Jul 2016 16:35:44 -0400 From: Johannes Weiner To: Guenter Roeck Cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] mm: Drop unnecessary include file Message-ID: <20160725203544.GA14491@cmpxchg.org> References: <1469339408-9240-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1469339408-9240-1-git-send-email-linux@roeck-us.net> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 23, 2016 at 10:50:08PM -0700, Guenter Roeck wrote: > Commmit e9be930fa6b5 ("mm: fix vm-scalability regression in cgroup-aware > workingset code") adds '#include ' to > include/linux/memcontrol.h. This results in the following build error > when building hexagon images. > > In file included from ./include/linux/memcontrol.h:32:0, > from ./include/linux/swap.h:8, > from ./arch/hexagon/include/asm/pgtable.h:27, > from mm/init-mm.c:9: > ./include/linux/mm.h:322:2: error: unknown type name 'pmd_t' > ./include/linux/mm.h:353:7: error: unknown type name 'pmd_t' > ./include/linux/mm.h:414:30: error: unknown type name 'pmd_t' > > The include file does not appear to be necessary, so just drop it. > > Fixes: e9be930fa6b5 ("mm: fix vm-scalability regression in cgroup-aware workingset code") > Cc: Johannes Weiner > Signed-off-by: Guenter Roeck It was needed because mem_cgroup_zone_zoneinfo() used zone_to_nid(). Mel's nodelru patches have since renamed it to mem_cgroup_nodeinfo() and dropped the zone_to_nid() reference, that's why it's no longer necessary. Acked-by: Johannes Weiner [ I'd put it in after the nodelru patches, though, to maintain bisectability on x86 over hexagon. ]