From: Wolfram Sang <wsa@the-dreams.de>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: ks7010: declare private functions static
Date: Tue, 26 Jul 2016 08:51:14 +0200 [thread overview]
Message-ID: <20160726065114.GD1772@katana> (raw)
In-Reply-To: <20160726064800.GB30333@osadl.at>
[-- Attachment #1: Type: text/plain, Size: 1351 bytes --]
On Tue, Jul 26, 2016 at 06:48:00AM +0000, Nicholas Mc Guire wrote:
> On Mon, Jul 25, 2016 at 11:04:18PM +0200, Wolfram Sang wrote:
> > On Mon, Jul 25, 2016 at 09:22:27PM +0200, Nicholas Mc Guire wrote:
> > > Private functions in ks_hostif.c can be declared static.
> > >
> > > Fixes: 13a9930d15b4 ("staging: ks7010: add driver from Nanonote extra-repository")
> > >
> > > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> >
> > Reviewed-by: Wolfram Sang <wsa@the-dreams.de>
> >
> > drivers/staging/ks7010/ks7010_sdio.c and
> > drivers/staging/ks7010/ks_wlan_net.c have similar warnings in case you'd
> > like to fix those, too.)
> >
> the cases found regarding completion were:
> ./drivers/staging/ks7010/ks_hostif.c:80 treating signal case as success
> ./drivers/staging/ks7010/ks_wlan_net.c:109 treating signal case as success
> ./drivers/staging/ks7010/ks7010_sdio.c:901 treating signal case as success
> ./drivers/staging/ks7010/ks7010_sdio.c:929 treating signal case as success
> ./drivers/video/fbdev/exynos/exynos_mipi_dsi_common.c:383 treating signal case as success
> ./drivers/video/fbdev/exynos/exynos_mipi_dsi_common.c:247 treating signal case as success
>
> will be going through all of them in the next days.
Awesome, thanks!
I meant the "should it be static?" sparse warnings here, though :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-07-26 6:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 19:22 [PATCH] staging: ks7010: declare private functions static Nicholas Mc Guire
2016-07-25 21:04 ` Wolfram Sang
2016-07-26 6:48 ` Nicholas Mc Guire
2016-07-26 6:51 ` Wolfram Sang [this message]
2016-07-26 6:54 ` Nicholas Mc Guire
-- strict thread matches above, loose matches on Subject: below --
2016-09-27 17:39 Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160726065114.GD1772@katana \
--to=wsa@the-dreams.de \
--cc=der.herr@hofr.at \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hofrat@osadl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox