From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754324AbcGZGv0 (ORCPT ); Tue, 26 Jul 2016 02:51:26 -0400 Received: from sauhun.de ([89.238.76.85]:58538 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752120AbcGZGvX (ORCPT ); Tue, 26 Jul 2016 02:51:23 -0400 Date: Tue, 26 Jul 2016 08:51:14 +0200 From: Wolfram Sang To: Nicholas Mc Guire Cc: Nicholas Mc Guire , Greg Kroah-Hartman , Wolfram Sang , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: ks7010: declare private functions static Message-ID: <20160726065114.GD1772@katana> References: <1469474547-15592-1-git-send-email-hofrat@osadl.org> <20160725210418.GD1698@katana> <20160726064800.GB30333@osadl.at> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="n2Pv11Ogg/Ox8ay5" Content-Disposition: inline In-Reply-To: <20160726064800.GB30333@osadl.at> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --n2Pv11Ogg/Ox8ay5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 26, 2016 at 06:48:00AM +0000, Nicholas Mc Guire wrote: > On Mon, Jul 25, 2016 at 11:04:18PM +0200, Wolfram Sang wrote: > > On Mon, Jul 25, 2016 at 09:22:27PM +0200, Nicholas Mc Guire wrote: > > > Private functions in ks_hostif.c can be declared static.=20 > > >=20 > > > Fixes: 13a9930d15b4 ("staging: ks7010: add driver from Nanonote extra= -repository") > > >=20 > > > Signed-off-by: Nicholas Mc Guire > >=20 > > Reviewed-by: Wolfram Sang > >=20 > > drivers/staging/ks7010/ks7010_sdio.c and > > drivers/staging/ks7010/ks_wlan_net.c have similar warnings in case you'd > > like to fix those, too.) > >=20 > the cases found regarding completion were: > ./drivers/staging/ks7010/ks_hostif.c:80 treating signal case as success > ./drivers/staging/ks7010/ks_wlan_net.c:109 treating signal case as success > ./drivers/staging/ks7010/ks7010_sdio.c:901 treating signal case as success > ./drivers/staging/ks7010/ks7010_sdio.c:929 treating signal case as success > ./drivers/video/fbdev/exynos/exynos_mipi_dsi_common.c:383 treating signal= case as success > ./drivers/video/fbdev/exynos/exynos_mipi_dsi_common.c:247 treating signal= case as success >=20 > will be going through all of them in the next days.=20 Awesome, thanks! I meant the "should it be static?" sparse warnings here, though :) --n2Pv11Ogg/Ox8ay5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXlwhiAAoJEBQN5MwUoCm2Y1kP/0R3mv+8PyW5DrvR6YBP+KQA 3DKklJ9X9zBKElEiaqgcR0rht//QGRGt9egtEWpA5QR5ZTrsh4Rz//BULmncvr4C +PfnptS/ynz/uLfXKom/ZeQ8k+KUVA67tQi/7vUDn/vSVpdGOhGt+IwDM0KFAjaU g9RmUhMRvFTyHGUL9g7qCG5mXYHJ28swclLtybmGY7/qBAZrFuHMRi/jzSKhRtil FPleZD6q3IP4k6q37cGVy48II4HnhZt3Zhxl0jK69ptLs1FHVAtYmRnwXLPFQqNx q+Rp0RPQR+EA7/Qs0fhq3Km/ridCXt9Wif2KaDx6yYU/UPJOzwq6h304KpGPTW4I kIVTT8Q9+5bARefDQVyHd20LtbQMgaq1UrG+pTznGkLOooI8Hbge9NvuRVnzpFlC BYceqMM0JNaXtysNmlt/Ae9IDdumUMbl15pZnt/a3CXIQpsu9AxfTRsmHmdv0g09 e6zmM8ucFqyl9wwpKDQjjJyqV0fXB6vz8tL1WEKU/OPP99FzldzukoCREO2VS5IZ LvhyQ34Pb2cWI0Wvhr1BBd4z7049nmlVxHI6r2333sCeizZ45FhXDrXkGsYWWI9q X026lupv9POBScG/SEJ6MOfrbXzxfsGXJqHPab1jwa6w1ryreXJYFRFRL7IKSaKy nVTr5AoRtH9x60iL13Go =hkhT -----END PGP SIGNATURE----- --n2Pv11Ogg/Ox8ay5--