From: Jiri Olsa <jolsa@redhat.com>
To: Songshan Gong <gongss@linux.vnet.ibm.com>
Cc: acme@kernel.org, jolsa@kernel.org, dsahern@gmail.com,
linux-kernel@vger.kernel.org, borntraeger@de.ibm.com
Subject: Re: [PATCH] s390/perf: fix 'start' address of module's map
Date: Tue, 26 Jul 2016 08:54:33 +0200 [thread overview]
Message-ID: <20160726065433.GA4517@krava> (raw)
In-Reply-To: <ef75cf02-524a-fd90-3d47-d9de4f1c5d67@linux.vnet.ibm.com>
On Fri, Jul 22, 2016 at 10:47:34AM +0800, Songshan Gong wrote:
> Has the patch been accepted by upstream?
>
> 在 7/21/2016 11:10 AM, Song Shan Gong 写道:
> > At preset, when creating module's map, perf gets 'start' address by parsing
> > '/proc/modules', but it's module base address, isn't the start address of
> > '.text' section. In most archs, it's OK. But for s390, it places 'GOT' and
> > 'PLT' relocations before '.text' section. So there exists an offset between
> > module base address and '.text' section, which will incur wrong symbol
> > resolution for modules.
> >
> > Fix this bug by getting 'start' address of module's map from parsing
> > '/sys/module/[module name]/sections/.text', not from '/proc/modules'.
> >
> > Signed-off-by: Song Shan Gong <gongss@linux.vnet.ibm.com>
> > Acked-by: Jiri Olsa <jolsa@kernel.org>
I think it's good to go, Arnaldo, could you please take this one?
thanks,
jirka
next prev parent reply other threads:[~2016-07-26 6:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 3:10 [RFC PATCH V4]s390/perf:fix 'start' address of module's map Song Shan Gong
2016-07-21 3:10 ` [PATCH] s390/perf: fix " Song Shan Gong
2016-07-22 2:47 ` Songshan Gong
2016-07-26 6:54 ` Jiri Olsa [this message]
2016-07-26 19:50 ` Arnaldo Carvalho de Melo
2016-07-26 20:14 ` Christian Borntraeger
2016-07-26 20:29 ` Arnaldo Carvalho de Melo
2016-07-27 9:24 ` Michael Ellerman
2016-07-27 13:05 ` Arnaldo Carvalho de Melo
2016-07-27 10:10 ` Songshan Gong
2016-07-27 10:49 ` Songshan Gong
2016-07-27 13:08 ` Arnaldo Carvalho de Melo
2016-07-28 2:01 ` Songshan Gong
2016-07-27 10:05 ` Songshan Gong
2016-07-27 10:41 ` [tip:perf/urgent] perf s390: Fix " tip-bot for Song Shan Gong
-- strict thread matches above, loose matches on Subject: below --
2016-07-19 11:31 [RFC PATCH V3]s390/perf:fix " Song Shan Gong
2016-07-19 11:31 ` [PATCH] s390/perf: fix " Song Shan Gong
2016-07-20 11:51 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160726065433.GA4517@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=borntraeger@de.ibm.com \
--cc=dsahern@gmail.com \
--cc=gongss@linux.vnet.ibm.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox