From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755294AbcGZHmM (ORCPT ); Tue, 26 Jul 2016 03:42:12 -0400 Received: from down.free-electrons.com ([37.187.137.238]:53250 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754019AbcGZHmJ (ORCPT ); Tue, 26 Jul 2016 03:42:09 -0400 Date: Tue, 26 Jul 2016 09:42:07 +0200 From: Alexandre Belloni To: Wei Yongjun Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] rtc: at91sam9: Fix missing spin_lock_init() Message-ID: <20160726074207.GO11405@piout.net> References: <1469430311-8651-1-git-send-email-weiyj.lk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1469430311-8651-1-git-send-email-weiyj.lk@gmail.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/07/2016 at 07:05:11 +0000, Wei Yongjun wrote : > The driver allocates the spinlock but not initialize it. > Use spin_lock_init() on it to initialize it correctly. > > This is detected by Coccinelle semantic patch. > > Signed-off-by: Wei Yongjun > --- > drivers/rtc/rtc-at91sam9.c | 1 + > 1 file changed, 1 insertion(+) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com