From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755613AbcGZHq5 (ORCPT ); Tue, 26 Jul 2016 03:46:57 -0400 Received: from mx2.suse.de ([195.135.220.15]:47160 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753665AbcGZHqz (ORCPT ); Tue, 26 Jul 2016 03:46:55 -0400 Date: Tue, 26 Jul 2016 08:46:50 +0100 From: Mel Gorman To: Minchan Kim Cc: Andrew Morton , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Vladimir Davydov Subject: Re: [RFC] mm: bail out in shrin_inactive_list Message-ID: <20160726074650.GW11400@suse.de> References: <1469433119-1543-1-git-send-email-minchan@kernel.org> <20160725092909.GV11400@suse.de> <20160726012157.GA11651@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20160726012157.GA11651@bbox> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 26, 2016 at 10:21:57AM +0900, Minchan Kim wrote: > > > I believe proper fix is to modify get_scan_count. IOW, I think > > > we should introduce lruvec_reclaimable_lru_size with proper > > > classzone_idx but I don't know how we can fix it with memcg > > > which doesn't have zone stat now. should introduce zone stat > > > back to memcg? Or, it's okay to ignore memcg? > > > > > > > I think it's ok to ignore memcg in this case as a memcg shrink is often > > going to be for pages that can use highmem anyway. > > So, you mean it's okay to ignore kmemcg case? > If memcg guys agree it, I want to make get_scan_count consider > reclaimable lru size under the reclaim constraint, instead. > For now, I believe yet. My understanding is that the primary use cases for kmemcg is systems running large numbers of containers. It consider it extremely unlikely that large 32-bit systems are being used for large numbers of containers and require usage of kmemcg. -- Mel Gorman SUSE Labs