From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757167AbcGZPd5 (ORCPT ); Tue, 26 Jul 2016 11:33:57 -0400 Received: from down.free-electrons.com ([37.187.137.238]:35821 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752998AbcGZPdz (ORCPT ); Tue, 26 Jul 2016 11:33:55 -0400 Date: Tue, 26 Jul 2016 17:33:52 +0200 From: Maxime Ripard To: Stefan Mavrodiev Cc: dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@armlinux.org.uk, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v4] ARM: dts: sun8i: Add dts file for Olimex A33-OLinuXino Message-ID: <20160726153352.GH7190@lukather> References: <1469450243-19138-1-git-send-email-stefan.mavrodiev@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AqCDj3hiknadvR6t" Content-Disposition: inline In-Reply-To: <1469450243-19138-1-git-send-email-stefan.mavrodiev@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --AqCDj3hiknadvR6t Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Stefan, On Mon, Jul 25, 2016 at 03:37:23PM +0300, Stefan Mavrodiev wrote: > A33-OLinuXino is A33 development board designed by Olimex LTD. >=20 > It has AXP233 PMU, 1GB DRAM, a micro SD card, one USB-OTG connector, > headphone and mic jacks, connector for LiPo battery and optional > 4GB NAND Flash. >=20 > It has two 40-pin headers. One for LCD panel, and one for > additional modules. Also there is CSI/DSI connector. >=20 > Signed-off-by: Stefan Mavrodiev It looks mostly good, a few comments though. > +&pio { > + led_pin_olinuxino: led_pins@0 { > + allwinner,pins =3D "PB7"; > + allwinner,function =3D "gpio_out"; This line is not properly indented. > + allwinner,drive =3D ; > + allwinner,pull =3D ; > + }; And this one too. > +®_dc1sw { > + regulator-name =3D "vcc-lcd"; > +}; No constraints on this one? > +®_dcdc1 { > + regulator-always-on; > + regulator-min-microvolt =3D <3300000>; > + regulator-max-microvolt =3D <3300000>; > + regulator-name =3D "vcc-dsi"; > +}; What is it used for? Is it really necessary to keep it on at all time? Thanks, Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --AqCDj3hiknadvR6t Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXl4LgAAoJEBx+YmzsjxAgMl8P/29IrklnFacdC/KtU7OGn0Uu 4jSj2C6CjOPA7iTBUc0fRQ/Oisgg0opiYVLt9mw6xDgjoTnzDa5YkI1tybHYal+x 6OPVnvetY658ElRqExZ8HlbUzgYbbUZHehngTAPBMY5c3y3ZaAnJRMoqgC5Afp1z y0lZx2KPlp0neRlb6ArMMW8r9xx7VyVHySB5KXbotG2xMa4G7RrLdeQJQPNFU2nO xr5RkBPwDg8SSgXGE93nkTL22Rbo02eTFH4di3qrcMJDLnwIw0v3+ZtzjSuYEl9s Tld7csRjxPprqoAl7YcUHir9CPzep3CB5OTG/wD6AIV05uPM7kkx0FjUssgLX4BA taWvWxYdxVTfWgWoVE4trEB/KRRnhx6u8DAZwLdXS3Ga39anc0UBLps0LiUtZPJe PSUj2QOL1zDRFEXlF7blI6dkCuQ4hJzcEi9E7XGDvalq0X7pcfdgwsDTTP31270j asgUd5t3C8nMnpaPEs1MZUnXZBzM/5jk3VwBaqXYKSDlwlLrtQyFdNAhV1n30xWv TCQBi53Iue0G+35sxUZWlj9YP5ndG0AXHMYCqpf4HiPIWzbsUsXHteNtXX2bOHRs qJ4MSaNAAxJSoxEc820kntnT2ArFEGVmjRvdiGZRZC5MYuKvm7PYctbMXTnmTCOL Ma/kv0iLorWEdqDAcL0W =6Rs2 -----END PGP SIGNATURE----- --AqCDj3hiknadvR6t--