From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757551AbcGZRnh (ORCPT ); Tue, 26 Jul 2016 13:43:37 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:38180 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757462AbcGZRnf (ORCPT ); Tue, 26 Jul 2016 13:43:35 -0400 Date: Tue, 26 Jul 2016 18:43:31 +0100 From: Andy Whitcroft To: Joe Perches Cc: Andrew Morton , Alan Douglas , linux-kernel@vger.kernel.org Subject: Re: [PATCH] checkpatch: Improve 'bare use of' signed/unsigned types warning Message-ID: <20160726174331.GN6746@brain> References: <6a0e24c3e9102337528ecfcbbe91a0eb5b4820ed.1469529497.git.joe@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a0e24c3e9102337528ecfcbbe91a0eb5b4820ed.1469529497.git.joe@perches.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 26, 2016 at 03:40:21AM -0700, Joe Perches wrote: > Fix false positive warning of identifiers ending in signed with an = > assignment of WARNING: Prefer 'signed int' to bare use of 'signed'. > > Reported-by: Alan Douglas > Signed-off-by: Joe Perches > --- > scripts/checkpatch.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 77915e0..1d5b09d 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -3347,7 +3347,7 @@ sub process { > next if ($line =~ /^[^\+]/); > > # check for declarations of signed or unsigned without int > - while ($line =~ m{($Declare)\s*(?!char\b|short\b|int\b|long\b)\s*($Ident)?\s*[=,;\[\)\(]}g) { > + while ($line =~ m{\b($Declare)\s*(?!char\b|short\b|int\b|long\b)\s*($Ident)?\s*[=,;\[\)\(]}g) { > my $type = $1; > my $var = $2; > $var = "" if (!defined $var); > -- > 2.8.0.rc4.16.g56331f8 > Derp, yes. Acked-by: Andy Whitcroft -apw