* [PATCH] checkpatch: Improve 'bare use of' signed/unsigned types warning
@ 2016-07-26 10:40 Joe Perches
2016-07-26 17:43 ` Andy Whitcroft
0 siblings, 1 reply; 2+ messages in thread
From: Joe Perches @ 2016-07-26 10:40 UTC (permalink / raw)
To: Andrew Morton, Andy Whitcroft; +Cc: Alan Douglas, linux-kernel
Fix false positive warning of identifiers ending in signed with an =
assignment of WARNING: Prefer 'signed int' to bare use of 'signed'.
Reported-by: Alan Douglas <alanjhd@gmail.com>
Signed-off-by: Joe Perches <joe@perches.com>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 77915e0..1d5b09d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3347,7 +3347,7 @@ sub process {
next if ($line =~ /^[^\+]/);
# check for declarations of signed or unsigned without int
- while ($line =~ m{($Declare)\s*(?!char\b|short\b|int\b|long\b)\s*($Ident)?\s*[=,;\[\)\(]}g) {
+ while ($line =~ m{\b($Declare)\s*(?!char\b|short\b|int\b|long\b)\s*($Ident)?\s*[=,;\[\)\(]}g) {
my $type = $1;
my $var = $2;
$var = "" if (!defined $var);
--
2.8.0.rc4.16.g56331f8
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] checkpatch: Improve 'bare use of' signed/unsigned types warning
2016-07-26 10:40 [PATCH] checkpatch: Improve 'bare use of' signed/unsigned types warning Joe Perches
@ 2016-07-26 17:43 ` Andy Whitcroft
0 siblings, 0 replies; 2+ messages in thread
From: Andy Whitcroft @ 2016-07-26 17:43 UTC (permalink / raw)
To: Joe Perches; +Cc: Andrew Morton, Alan Douglas, linux-kernel
On Tue, Jul 26, 2016 at 03:40:21AM -0700, Joe Perches wrote:
> Fix false positive warning of identifiers ending in signed with an =
> assignment of WARNING: Prefer 'signed int' to bare use of 'signed'.
>
> Reported-by: Alan Douglas <alanjhd@gmail.com>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 77915e0..1d5b09d 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3347,7 +3347,7 @@ sub process {
> next if ($line =~ /^[^\+]/);
>
> # check for declarations of signed or unsigned without int
> - while ($line =~ m{($Declare)\s*(?!char\b|short\b|int\b|long\b)\s*($Ident)?\s*[=,;\[\)\(]}g) {
> + while ($line =~ m{\b($Declare)\s*(?!char\b|short\b|int\b|long\b)\s*($Ident)?\s*[=,;\[\)\(]}g) {
> my $type = $1;
> my $var = $2;
> $var = "" if (!defined $var);
> --
> 2.8.0.rc4.16.g56331f8
>
Derp, yes.
Acked-by: Andy Whitcroft <apw@canonical.com>
-apw
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-26 17:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-26 10:40 [PATCH] checkpatch: Improve 'bare use of' signed/unsigned types warning Joe Perches
2016-07-26 17:43 ` Andy Whitcroft
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox