From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757561AbcGZR7M (ORCPT ); Tue, 26 Jul 2016 13:59:12 -0400 Received: from mail-qt0-f169.google.com ([209.85.216.169]:36615 "EHLO mail-qt0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757465AbcGZR7I (ORCPT ); Tue, 26 Jul 2016 13:59:08 -0400 Date: Tue, 26 Jul 2016 13:58:45 -0400 From: Jarod Wilson To: Jeff Kirsher Cc: linux-kernel@vger.kernel.org, Jesse Brandeburg , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next 3/2] e1000e: convert systim overflow check to use flags2 Message-ID: <20160726175845.GT36313@redhat.com> References: <20160725105648.00000dda@unknown> <1469554746-410-1-git-send-email-jarod@redhat.com> <1469555635.2851.10.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1469555635.2851.10.camel@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 26, 2016 at 10:53:55AM -0700, Jeff Kirsher wrote: > On Tue, 2016-07-26 at 13:39 -0400, Jarod Wilson wrote: > > Per Jesse Brandeburg, e1000e should be using flags for this sort of > > thing. > > > > Littering functional code with device-specific checks is much messier > > than > > simply checking a flag, and having device-specific init set flags as > > needed. > > There are probably a number of other cases in the e1000e code that > > could/should be converted similarly. > > > > At present, this patch is a follow-up to the previously submitted 2 > > patches, but I can redo the series to omit the conversion to a switch > > entirely, if so desired. > > > > Suggested-by: Jesse Brandeburg > > CC: Jesse Brandeburg > > CC: Jeff Kirsher > > CC: intel-wired-lan@lists.osuosl.org > > CC: netdev@vger.kernel.org > > Signed-off-by: Jarod Wilson > > --- > >  drivers/net/ethernet/intel/e1000e/82571.c   |  6 ++++-- > >  drivers/net/ethernet/intel/e1000e/e1000.h   |  1 + > >  drivers/net/ethernet/intel/e1000e/ich8lan.c |  3 ++- > >  drivers/net/ethernet/intel/e1000e/netdev.c  | 10 ++-------- > >  4 files changed, 9 insertions(+), 11 deletions(-) > > This generates a compile issue, so I will be dropping this patch and will > await an update. Yeah, just sent a note off-list, I really shouldn't send patches while on conference calls. It's a typo in ich8lan.c, where I put FLAGS2_ instead of FLAG2_. I'll just redo the entire set omitting the switch conversion. -- Jarod Wilson jarod@redhat.com