Re: [PATCH v2 02/22] usb: serial: ti_usb_3410_5052: Remove useless dev_dbg messages

Johan Hovold
2016-08-23T07:52:06Z

On Tue, Jul 26, 2016 at 07:59:42PM +0200, Mathieu OTHACEHE wrote:
> Remove useless or redundant dev_dbg messages.
> Fix debug-message typos.

You never fix any typos, and forgot to mention the added NULL-check for
oldtermios, which is currently not needed and really should go in its
own patch.

> Signed-off-by: Mathieu OTHACEHE <m.othacehe@gmail.com>
> ---
> Changelog:
> v2:
> * Keep some debug messages
>
> drivers/usb/serial/ti_usb_3410_5052.c | 23 +++++++++--------------
> 1 file changed, 9 insertions(+), 14 deletions(-)

> @@ -967,9 +956,15 @@ static void ti_set_termios(struct tty_struct *tty,
> cflag = tty->termios.c_cflag;
> iflag = tty->termios.c_iflag;
>
> - dev_dbg(&port->dev, "%s - cflag %08x, iflag %08x\n", __func__, cflag, iflag);
> - dev_dbg(&port->dev, "%s - old clfag %08x, old iflag %08x\n", __func__,
> - old_termios->c_cflag, old_termios->c_iflag);
> + dev_dbg(&port->dev,
> + "%s - cflag 0x%08x, iflag 0x%08x\n", __func__, cflag, iflag);
> +
> + if (old_termios) {
> + dev_dbg(&port->dev, "%s - old clfag 0x%08x, old iflag 0x%08x\n",

Notice that "clfag" is still misspelled.

> + __func__,
> + old_termios->c_cflag,
> + old_termios->c_iflag);
> + }
>
> if (tport == NULL)
> return;

So, I dropped this chunk, and applied the rest.

Thanks,
Johan