Re: [PATCH v2 10/22] usb: serial: ti_usb_3410_5052: Change ti_write_byte function arguments

Oliver Neukum
2016-07-27T08:18:14Z

On Tue, 2016-07-26 at 19:59 +0200, Mathieu OTHACEHE wrote:
> @@ -1626,7 +1624,7 @@ static int ti_write_byte(struct usb_serial_port
> *port,
> data->bAddrType = TI_RW_DATA_ADDR_XDATA;
> data->bDataType = TI_RW_DATA_BYTE;
> data->bDataCounter = 1;
> - data->wBaseAddrHi = cpu_to_be16(addr>>16);
> + data->wBaseAddrHi = cpu_to_be16(addr >> 16);
> data->wBaseAddrLo = cpu_to_be16(addr);
> data->bData[0] = mask;
> data->bData[1] = byte;
> --

Hi,

this makes me think something is wrong with the data structure.
We should have a be32 there, it seems to me.

Regards
Oliver