Re: [PATCH v2 01/22] usb: serial: ti_usb_3410_5052: Do not use __uX types

Johan Hovold
2016-08-23T08:01:54Z

On Tue, Jul 26, 2016 at 07:59:41PM +0200, Mathieu OTHACEHE wrote:
> __uX types should only be used for user-space interactions.
>
> Signed-off-by: Mathieu OTHACEHE <m.othacehe@gmail.com>
> ---
>
> Changelog:
> v2:
> * Replace cpu_to_be16s calls by cpu_to_be16
> * Remove other useless casts

You should have mentioned this in the commit message as well (i.e. that
you're doing more than just replacing __uX types).

> drivers/usb/serial/ti_usb_3410_5052.c | 101 +++++++++++++++++-----------------
> 1 file changed, 51 insertions(+), 50 deletions(-)
>
> diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c
> index 07b4bf0..ebeea51 100644

> static int ti_do_download(struct usb_device *dev, int pipe,
> - u8 *buffer, int size)
> + u8 *buffer, int size)
> {
> int pos;
> u8 cs = 0;

I dropped this unrelated change, and amended the commit message before
applying.

Thanks,
Johan