From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757980AbcGZS3r (ORCPT ); Tue, 26 Jul 2016 14:29:47 -0400 Received: from foss.arm.com ([217.140.101.70]:41198 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757496AbcGZS3p (ORCPT ); Tue, 26 Jul 2016 14:29:45 -0400 Date: Tue, 26 Jul 2016 19:29:33 +0100 From: Mark Rutland To: Lin Huang Cc: heiko@sntech.de, tixy@linaro.org, typ@rock-chips.com, linux-rockchip@lists.infradead.org, airlied@linux.ie, mturquette@baylibre.com, dbasehore@chromium.org, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, dianders@chromium.org, xsf@rock-chips.com, cw00.choi@samsung.com, kyungmin.park@samsung.com, myungjoo.ham@samsung.com, linux-arm-kernel@lists.infradead.org, mark.yao@rock-chips.com Subject: Re: [PATCH v3 1/7] firmware: rockchip: sip: Add rockchip SIP runtime service Message-ID: <20160726182933.GA2288@leverpostej> References: <1469178440-4668-1-git-send-email-hl@rock-chips.com> <1469178440-4668-2-git-send-email-hl@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1469178440-4668-2-git-send-email-hl@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 22, 2016 at 05:07:14PM +0800, Lin Huang wrote: > +config ROCKCHIP_SIP > + bool "Rockchip SIP interface" > + depends on ARM64 && ARM_PSCI_FW > + help > + Say Y here if you want to enable SIP callbacks for Rockchip platforms > + This option enables support for communicating with the ATF. [...] > +typedef unsigned long (psci_fn)(unsigned long, unsigned long, > + unsigned long, unsigned long); > +asmlinkage psci_fn __invoke_psci_fn_smc; Use the SMCCC wrappers (see include/linux/arm-smccc.h). This is *not* PSCI, even if the same ATF FW provides both services. NAK for using the PSCI functions. Thanks, Mark.