From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757995AbcGZSuk (ORCPT ); Tue, 26 Jul 2016 14:50:40 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:35675 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752416AbcGZSui (ORCPT ); Tue, 26 Jul 2016 14:50:38 -0400 Date: Tue, 26 Jul 2016 21:50:30 +0300 From: Max Filippov To: Rob Herring Cc: Chris Zankel , linux-kernel@vger.kernel.org, linux-xtensa@linux-xtensa.org, Kefeng Wang , Guenter Roeck Subject: Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary of_platform_populate with default match table" Message-ID: <20160726185030.GA1787@octofox.metropolis> References: <20160726180132.12764-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160726180132.12764-1-robh@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 26, 2016 at 01:01:32PM -0500, Rob Herring wrote: > This partially reverts commit 69d99e6c0d62 keeping only the main > purpose of the original commit which is the removal of > of_platform_populate() call. The moving of of_clk_init() caused changes > in the initialization order breaking booting. > > Fixes: 69d99e6c0d621f ("xtensa: Remove unnecessary of_platform_populate with default match table") > Cc: Kefeng Wang > Cc: Guenter Roeck > Cc: Max Filippov > Signed-off-by: Rob Herring > --- > This is on top of Guenter's build fix. Please test and I'll apply. I Tested-by: Max Filippov > tried briefly running under QEMU, but didn't have success. If anyone has > up to date instructions that would be helpful as using these[1] didn't > seem to work. I think they're up to date. Another thing that need to be done right is the toolchain: it must match the configured CPU core. Please refer to http://wiki.linux-xtensa.org/index.php/Toolchain_Overlay_File for more details. > > [1] http://wiki.linux-xtensa.org/index.php/Xtensa_on_QEMU > > arch/xtensa/kernel/setup.c | 9 +++++++++ > arch/xtensa/kernel/time.c | 2 -- > 2 files changed, 9 insertions(+), 2 deletions(-) -- Thanks. -- Max