From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758219AbcGZUVk (ORCPT ); Tue, 26 Jul 2016 16:21:40 -0400 Received: from mail.kernel.org ([198.145.29.136]:46868 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757978AbcGZUVi (ORCPT ); Tue, 26 Jul 2016 16:21:38 -0400 Date: Tue, 26 Jul 2016 15:21:34 -0500 From: Bjorn Helgaas To: Rui Wang Cc: tglx@linutronix.de, rjw@rjwysocki.net, tony.luck@intel.com, bhelgaas@google.com, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] x86/ioapic: Fix setup_res() failing to get resource Message-ID: <20160726202134.GE15037@localhost> References: <1469549597-19253-1-git-send-email-rui.y.wang@intel.com> <1469549597-19253-3-git-send-email-rui.y.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1469549597-19253-3-git-send-email-rui.y.wang@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 27, 2016 at 12:13:15AM +0800, Rui Wang wrote: > setup_res() doesn't actually get any resoure because it mistakenly s/resoure/resource/ > checks the return value of acpi_dev_filter_resource_type(), which > returns 0 on success, and 1 on failure. Fix it by taking the return > value of non-zero as failing to match the specified resource type. > > Signed-off-by: Rui Wang > --- > drivers/acpi/ioapic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/ioapic.c b/drivers/acpi/ioapic.c > index 0f272e2..daf4a40 100644 > --- a/drivers/acpi/ioapic.c > +++ b/drivers/acpi/ioapic.c > @@ -46,7 +46,7 @@ static acpi_status setup_res(struct acpi_resource *acpi_res, void *data) > struct resource_win win; > > res->flags = 0; > - if (acpi_dev_filter_resource_type(acpi_res, IORESOURCE_MEM) == 0) > + if (acpi_dev_filter_resource_type(acpi_res, IORESOURCE_MEM)) > return AE_OK; > > if (!acpi_dev_resource_memory(acpi_res, res)) { > -- > 1.8.3.1 >