From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757309AbcG0EZf (ORCPT ); Wed, 27 Jul 2016 00:25:35 -0400 Received: from mail.kernel.org ([198.145.29.136]:34962 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750701AbcG0EZ1 (ORCPT ); Wed, 27 Jul 2016 00:25:27 -0400 Date: Wed, 27 Jul 2016 07:25:21 +0300 From: Leon Romanovsky To: kys@microsoft.com Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, linux-rdma@vger.kernel.org, yishaih@mellanox.com, sean.hefty@intel.com, dledford@redhat.com, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com, leann.ogasawara@canonical.com, longli@microsoft.com Subject: Re: [PATCH 1/1] Drivers: infiniband: hw: vmbus-nd: NetworkDirect driver for Linux Message-ID: <20160727042521.GD4628@leon.nu> References: <1469585137-31229-1-git-send-email-kys@exchange.microsoft.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="x4pBfXISqBoDm8sr" Content-Disposition: inline In-Reply-To: <1469585137-31229-1-git-send-email-kys@exchange.microsoft.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --x4pBfXISqBoDm8sr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 26, 2016 at 07:05:37PM -0700, kys@exchange.microsoft.com wrote: > From: K. Y. Srinivasan >=20 > This driver is a bridge driver that surfaces a Mellanox device in the Lin= ux guest and plugs into > the "NetworkDirect" RDMA infrastructure on the Windows host. Only a subse= t of the ibverbs are > implemented (this decision is based on the verbs supported by the Windows= host). > The control path is implemented over the vmbus using the NetworkDirect pr= otocol for > virtualized environments. The data path bypasses the guest and host kerne= l and the NIC is able to RDMA > into guest addresses. >=20 > Signed-off-by: K. Y. Srinivasan > --- > drivers/infiniband/Kconfig | 1 + > drivers/infiniband/hw/Makefile | 1 + > drivers/infiniband/hw/vmbus-nd/Kconfig | 5 + > drivers/infiniband/hw/vmbus-nd/Makefile | 3 + > drivers/infiniband/hw/vmbus-nd/hvnd_addr.c | 292 +++ > drivers/infiniband/hw/vmbus-nd/mx_abi.h | 232 ++ > drivers/infiniband/hw/vmbus-nd/provider.c | 2844 +++++++++++++++++++++= +++ > drivers/infiniband/hw/vmbus-nd/vmbus_rdma.c | 3086 +++++++++++++++++++++= ++++++ > drivers/infiniband/hw/vmbus-nd/vmbus_rdma.h | 2205 +++++++++++++++++++ > 9 files changed, 8669 insertions(+), 0 deletions(-) If your final goal is to merge this driver into Linux kernel, so I will ask from you to do the following actions: 1. Split this patch to smaller patches to allow review. You can see as an example - latest submission of "Add Paravirtual RDMA Driv= er" [1]. 2. Fix licenses, magic numbers, remove creepy comments and learn about MAINTAINERS file. 3. Use preferred for this susbsystem title format. 4. Find the relevant mailing list and maintainer for this submission and don't add unrelated people. Thanks. [1] http://marc.info/?l=3Dlinux-rdma&m=3D146835226218818&w=3D2 > create mode 100644 drivers/infiniband/hw/vmbus-nd/Kconfig > create mode 100644 drivers/infiniband/hw/vmbus-nd/Makefile > create mode 100644 drivers/infiniband/hw/vmbus-nd/hvnd_addr.c > create mode 100644 drivers/infiniband/hw/vmbus-nd/mx_abi.h > create mode 100644 drivers/infiniband/hw/vmbus-nd/provider.c > create mode 100644 drivers/infiniband/hw/vmbus-nd/vmbus_rdma.c > create mode 100644 drivers/infiniband/hw/vmbus-nd/vmbus_rdma.h --x4pBfXISqBoDm8sr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXmDexAAoJEORje4g2clinxwsP+QE46+tl3k7HVz9//05xAlQw waU1Ly0TCgr/SzRiL/3q2feHfKFqeMMivNESnGW2TUA4tNf1YE5z4lvvWDOvdK0p 2EXJuQTGLFCPwb4sK0y+ct9za8TW7efUw+VZYhgjleuBEDnx/dNojJsmHll1CvSI TrSBkMKoChZ1UbSC+mfPvzabejhVv0q03NOCm/EbjoEtYkH7w7Pf8ebJiUjGIm5R exQ/6/xMzLgd5kobiVcasYVwCJ4tVIEyDhPIm3+khNxpjqLr0rSwmapSesaa0VEq ZtaROmpTTRPSbShDxTtsNlAXdvpyYtxqwrY7hODfE2ZcNWSl/B1LWWx9VoY9s8pY ECXmfFVo6LuP84LrZLd0ymuojsDd+J/Jxxtk1RJytmOrgFKLdwSENNte33ch1/dj 4QI5FSmFul9T0vKHW41WV5REM6dqLtDFf/zbtASy9j/iYpK7ZDXScOgVPpCMLhsO 16l6lrmHON/iipXE1lbzLWZl/zd3txNZVk1PPg+DcKYuUfkNzJMMpcNMKRWJfvrz CeiDbgvqtmTip4iwHVzivNeM18aua1dcJSNHl+iL3tdpF24Vq2uqoPeWV49RUcGQ 2FIvBoC1VarRlna1BCpEoGxD6wQtx4KQQ4WgfPcL6LnatWfrm8FsU7Qv7ciAhesU 4vx28lHvEA56gSqfxsiU =PLIv -----END PGP SIGNATURE----- --x4pBfXISqBoDm8sr--