From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754244AbcG0JAg (ORCPT ); Wed, 27 Jul 2016 05:00:36 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:36699 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753345AbcG0JAd (ORCPT ); Wed, 27 Jul 2016 05:00:33 -0400 Date: Wed, 27 Jul 2016 11:00:28 +0200 From: Ingo Molnar To: Sai Praneeth Prakhya Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Dave Hansen , Yu-Cheng Yu , Fenghua Yu , Ravi Shankar Subject: Re: [PATCH] x86/fpu/xstate: Return error if xfeature bit is unset in XSAVES compacted-format buffer Message-ID: <20160727090028.GA30204@gmail.com> References: <1469480888-14363-1-git-send-email-sai.praneeth.prakhya@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1469480888-14363-1-git-send-email-sai.praneeth.prakhya@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Sai Praneeth Prakhya wrote: > From: Sai Praneeth > > Currently, XSAVES compacted-format buffer will always contain space for > all enabled states. If XSAVES compacted-format buffer is in use and > an xstate component (E.g: PKRU xstate) is not present in the buffer > (i.e. xcomp_bv does not have xfeature (E.g: XFEATURE_MASK_PKRU) bit > set), then fpu__xfeature_set_state() returns error. Please fix the changelog to conform to the standard changelog style: - first describe the symptoms of the bug - how does a user notice? - then describe how the code behaves today and how that is causing the bug - and then only describe how it's fixed. Thanks, Ingo