From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754314AbcG0JJY (ORCPT ); Wed, 27 Jul 2016 05:09:24 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:34958 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752547AbcG0JJV (ORCPT ); Wed, 27 Jul 2016 05:09:21 -0400 Date: Wed, 27 Jul 2016 14:39:16 +0530 From: Bhaktipriya Shridhar To: Greg Kroah-Hartman , Julia Lawall Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Tejun Heo Subject: [RFC] whci: Remove deprecated create_singlethread_workqueue Message-ID: <20160727090915.GA24974@Karyakshetra> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org alloc_ordered_workqueue replaces the deprecated create_singlethread_workqueue. The workqueue "workqueue" has multiple workitems which may require ordering. Hence, a dedicated ordered workqueue has been used. Since the workqueue is not being used on a memory reclaim path, WQ_MEM_RECLAIM has not been set. Can the workitems run concurrently? Is the ordering among work items necessary? Thanks. Signed-off-by: Bhaktipriya Shridhar --- drivers/usb/host/whci/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/whci/init.c b/drivers/usb/host/whci/init.c index e363723..ad8eb57 100644 --- a/drivers/usb/host/whci/init.c +++ b/drivers/usb/host/whci/init.c @@ -65,7 +65,7 @@ int whc_init(struct whc *whc) init_waitqueue_head(&whc->cmd_wq); init_waitqueue_head(&whc->async_list_wq); init_waitqueue_head(&whc->periodic_list_wq); - whc->workqueue = create_singlethread_workqueue(dev_name(&whc->umc->dev)); + whc->workqueue = alloc_ordered_workqueue(dev_name(&whc->umc->dev), 0); if (whc->workqueue == NULL) { ret = -ENOMEM; goto error; -- 2.1.4