From: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"GeyslanG.Bem@Karyakshetra" <geyslan@gmail.com>,
Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>,
Geliang Tang <geliangtang@163.com>,
Saurabh Karajgaonkar <skarajga@visteon.com>,
Mel Gorman <mgorman@techsingularity.net>,
Masanari Iida <standby24x7@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Tejun Heo <tj@kernel.org>
Subject: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue
Date: Wed, 27 Jul 2016 14:50:43 +0530 [thread overview]
Message-ID: <20160727092043.GA25086@Karyakshetra> (raw)
alloc_ordered_workqueue replaces the deprecated
create_singlethread_workqueue.
The workqueue "workqueue" has multiple workitems which may require
ordering. Hence, a dedicated ordered workqueue has been used.
Since the workqueue is not being used on a memory reclaim path,
WQ_MEM_RECLAIM has not been set.
Can the workitems run concurrently? Is the ordering among work items
necessary?
Thanks.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/usb/host/u132-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/u132-hcd.c b/drivers/usb/host/u132-hcd.c
index 43d5293..cbde189 100644
--- a/drivers/usb/host/u132-hcd.c
+++ b/drivers/usb/host/u132-hcd.c
@@ -3206,7 +3206,7 @@ static int __init u132_hcd_init(void)
if (usb_disabled())
return -ENODEV;
printk(KERN_INFO "driver %s\n", hcd_name);
- workqueue = create_singlethread_workqueue("u132");
+ workqueue = alloc_ordered_workqueue("u132", 0);
retval = platform_driver_register(&u132_platform_driver);
return retval;
}
--
2.1.4
next reply other threads:[~2016-07-27 9:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 9:20 Bhaktipriya Shridhar [this message]
2016-07-27 9:29 ` [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue Oliver Neukum
2016-07-27 18:00 ` Tejun Heo
2016-07-27 18:54 ` Alan Stern
2016-07-27 19:23 ` Tejun Heo
2016-07-27 20:45 ` Alan Stern
2016-07-29 13:11 ` Tejun Heo
2016-08-01 13:50 ` Michal Hocko
2016-08-01 14:20 ` Tejun Heo
2016-08-01 18:00 ` Alan Stern
2016-08-01 18:28 ` Michal Hocko
2016-08-02 8:06 ` Oliver Neukum
2016-08-02 8:18 ` Michal Hocko
2016-08-02 10:03 ` Oliver Neukum
2016-08-02 11:34 ` Michal Hocko
2016-08-02 11:44 ` Oliver Neukum
2016-08-02 12:48 ` Michal Hocko
2016-08-02 13:29 ` Oliver Neukum
2016-08-02 19:02 ` Tejun Heo
2016-08-02 21:26 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160727092043.GA25086@Karyakshetra \
--to=bhaktipriya96@gmail.com \
--cc=geliangtang@163.com \
--cc=geyslan@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=skarajga@visteon.com \
--cc=standby24x7@gmail.com \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox