* [PATCH] usb: gadget: remove redundant self assignment
@ 2016-07-25 21:57 Colin King
2016-07-27 9:27 ` Peter Chen
0 siblings, 1 reply; 5+ messages in thread
From: Colin King @ 2016-07-25 21:57 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman, Marek Szyprowski,
Ruslan Bilovol, Robert Baldyga, Yoshihiro Shimoda, linux-usb
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The assignment ret = ret is redundant and can be removed.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/usb/gadget/udc/core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
index ff8685e..48cf1a3 100644
--- a/drivers/usb/gadget/udc/core.c
+++ b/drivers/usb/gadget/udc/core.c
@@ -107,10 +107,8 @@ int usb_ep_enable(struct usb_ep *ep)
goto out;
ret = ep->ops->enable(ep, ep->desc);
- if (ret) {
- ret = ret;
+ if (ret)
goto out;
- }
ep->enabled = true;
--
2.8.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] usb: gadget: remove redundant self assignment
2016-07-25 21:57 [PATCH] usb: gadget: remove redundant self assignment Colin King
@ 2016-07-27 9:27 ` Peter Chen
0 siblings, 0 replies; 5+ messages in thread
From: Peter Chen @ 2016-07-27 9:27 UTC (permalink / raw)
To: Colin King
Cc: Felipe Balbi, Greg Kroah-Hartman, Marek Szyprowski,
Ruslan Bilovol, Robert Baldyga, Yoshihiro Shimoda, linux-usb,
linux-kernel
On Mon, Jul 25, 2016 at 10:57:36PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The assignment ret = ret is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/usb/gadget/udc/core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
> index ff8685e..48cf1a3 100644
> --- a/drivers/usb/gadget/udc/core.c
> +++ b/drivers/usb/gadget/udc/core.c
> @@ -107,10 +107,8 @@ int usb_ep_enable(struct usb_ep *ep)
> goto out;
>
> ret = ep->ops->enable(ep, ep->desc);
> - if (ret) {
> - ret = ret;
> + if (ret)
> goto out;
> - }
>
> ep->enabled = true;
>
Reviewed-by: Peter Chen <peter.chen@nxp.com>
--
Best Regards,
Peter Chen
^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <CGME20170417031117epcas5p3cba067df249c6f0fcfad0eb09eb20040@epcas5p3.samsung.com>]
* [PATCH] usb: gadget: remove redundant self assignment
@ 2017-04-17 3:12 ` Stefan Agner
2017-04-17 7:42 ` Peter Chen
2017-04-19 9:01 ` Krzysztof Opasiak
0 siblings, 2 replies; 5+ messages in thread
From: Stefan Agner @ 2017-04-17 3:12 UTC (permalink / raw)
To: balbi
Cc: gregkh, peter.chen, k.opasiak, yoshihiro.shimoda.uh, colin.king,
linux-usb, linux-kernel, Stefan Agner
The assignment ret = ret is redundant and can be removed.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
A very similar patch has been applied already last year, but there is
a second such assignment...
--
Stefan
drivers/usb/gadget/udc/core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
index d685d82dcf48..b57bd53812fe 100644
--- a/drivers/usb/gadget/udc/core.c
+++ b/drivers/usb/gadget/udc/core.c
@@ -139,10 +139,8 @@ int usb_ep_disable(struct usb_ep *ep)
goto out;
ret = ep->ops->disable(ep);
- if (ret) {
- ret = ret;
+ if (ret)
goto out;
- }
ep->enabled = false;
--
2.12.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] usb: gadget: remove redundant self assignment
2017-04-17 3:12 ` Stefan Agner
@ 2017-04-17 7:42 ` Peter Chen
2017-04-19 9:01 ` Krzysztof Opasiak
1 sibling, 0 replies; 5+ messages in thread
From: Peter Chen @ 2017-04-17 7:42 UTC (permalink / raw)
To: Stefan Agner
Cc: balbi, gregkh, peter.chen, k.opasiak, yoshihiro.shimoda.uh,
colin.king, linux-usb, linux-kernel
On Sun, Apr 16, 2017 at 08:12:50PM -0700, Stefan Agner wrote:
> The assignment ret = ret is redundant and can be removed.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> A very similar patch has been applied already last year, but there is
> a second such assignment...
>
> --
> Stefan
>
> drivers/usb/gadget/udc/core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
> index d685d82dcf48..b57bd53812fe 100644
> --- a/drivers/usb/gadget/udc/core.c
> +++ b/drivers/usb/gadget/udc/core.c
> @@ -139,10 +139,8 @@ int usb_ep_disable(struct usb_ep *ep)
> goto out;
>
> ret = ep->ops->disable(ep);
> - if (ret) {
> - ret = ret;
> + if (ret)
> goto out;
> - }
>
> ep->enabled = false;
>
Reviewed-by: Peter Chen <peter.chen@nxp.com>
--
Best Regards,
Peter Chen
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] usb: gadget: remove redundant self assignment
2017-04-17 3:12 ` Stefan Agner
2017-04-17 7:42 ` Peter Chen
@ 2017-04-19 9:01 ` Krzysztof Opasiak
1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Opasiak @ 2017-04-19 9:01 UTC (permalink / raw)
To: Stefan Agner, balbi
Cc: gregkh, peter.chen, yoshihiro.shimoda.uh, colin.king, linux-usb,
linux-kernel
On 04/17/2017 05:12 AM, Stefan Agner wrote:
> The assignment ret = ret is redundant and can be removed.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> A very similar patch has been applied already last year, but there is
> a second such assignment...
>
> --
> Stefan
>
> drivers/usb/gadget/udc/core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
> index d685d82dcf48..b57bd53812fe 100644
> --- a/drivers/usb/gadget/udc/core.c
> +++ b/drivers/usb/gadget/udc/core.c
> @@ -139,10 +139,8 @@ int usb_ep_disable(struct usb_ep *ep)
> goto out;
>
> ret = ep->ops->disable(ep);
> - if (ret) {
> - ret = ret;
> + if (ret)
> goto out;
> - }
>
> ep->enabled = false;
>
>
Reviewed-by: Krzysztof Opasiak <k.opasiak@samsung.com>
--
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-04-19 9:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-25 21:57 [PATCH] usb: gadget: remove redundant self assignment Colin King
2016-07-27 9:27 ` Peter Chen
[not found] <CGME20170417031117epcas5p3cba067df249c6f0fcfad0eb09eb20040@epcas5p3.samsung.com>
2017-04-17 3:12 ` Stefan Agner
2017-04-17 7:42 ` Peter Chen
2017-04-19 9:01 ` Krzysztof Opasiak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox