From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754842AbcG0KPr (ORCPT ); Wed, 27 Jul 2016 06:15:47 -0400 Received: from foss.arm.com ([217.140.101.70]:43876 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754062AbcG0KPq (ORCPT ); Wed, 27 Jul 2016 06:15:46 -0400 Date: Wed, 27 Jul 2016 11:15:38 +0100 From: Mark Rutland To: Rich Felker Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org, devicetree@vger.kernel.org, Jason Cooper , Marc Zyngier , Rob Herring , Thomas Gleixner Subject: Re: [PATCH v4 2/2] irqchip: add J-Core AIC driver Message-ID: <20160727101537.GD12880@leverpostej> References: <862a5642f4a30f062171bbc14fe95a729eab8ba2.1469595861.git.dalias@libc.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <862a5642f4a30f062171bbc14fe95a729eab8ba2.1469595861.git.dalias@libc.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 27, 2016 at 05:35:09AM +0000, Rich Felker wrote: > For simplicity, there is no aic1-specific logic in the driver beyond > setting the priority register, which is necessary for interrupts to > work at all. Eventually aic1 will likely be phased out, but it's > currently in use in deployments and all released bitstream binaries. [...] > + if (!of_device_is_compatible(node, "jcore,aic2")) { If this is only meant to run for AIC1, it would be better to check for the "jcore,aic1" compatible string explicitly. While that shouldn't matter much currently, it better matches the intent described in the commit message, and avoids surprises and/or churn in future if you have AIC3+. Mark. > +IRQCHIP_DECLARE(jcore_aic2, "jcore,aic2", aic_irq_of_init); > +IRQCHIP_DECLARE(jcore_aic1, "jcore,aic1", aic_irq_of_init); > -- > 2.8.1 >