Re: [PATCH v3 2/2] tpm: add driver for cr50 on SPI

Andrey Pronin
2016-07-29T03:01:09Z

On Thu, Jul 28, 2016 at 05:17:06PM -0600, Jason Gunthorpe wrote:
> On Thu, Jul 28, 2016 at 04:01:41PM -0700, Dmitry Torokhov wrote:
>
> > > + u8 tx_buf[MAX_SPI_FRAMESIZE];
> > > + u8 rx_buf[MAX_SPI_FRAMESIZE];
> >
> > Both of these need to be annotated as "____cacheline_aligned" since we
> > eye them for use in DMA transfers.
>
> Huh. That sure looks true to me..
>
> We make that same mistake in all other tpm SPI drivers.
>
> Can someone send a patch please?
>

Just did.

Thanks,
Andrey