Re: [PATCH v2 1/2] tpm: devicetree: document properties for cr50

Andrey Pronin
2016-07-27T21:02:38Z

On Wed, Jul 20, 2016 at 01:54:22PM -0600, Jason Gunthorpe wrote:
> On Wed, Jul 20, 2016 at 12:49:12PM -0700, Andrey Pronin wrote:
>
> > Sorry, I just updated this patch description in v2 to indicate why they are not
> > hard-coded, but didn't answer explicitly. As the firmware changes, a different
> > revision of it can have a different time before it sleeps in its configuration,
> > or the time it takes it to startup may be different. Thus, there's a way to
> > set it here w/o changing the driver.
>
> This sort of stuff should be read out of the firmware, not DT..
>
> Why has Google created such a non-standard TPM firmware???
>
> Jason

Thanks, Jason. Will hard-code those in the driver instead of reading
from DT.

Andrey