From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932758AbcG1ALk (ORCPT ); Wed, 27 Jul 2016 20:11:40 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33761 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932578AbcG1ALc (ORCPT ); Wed, 27 Jul 2016 20:11:32 -0400 Date: Thu, 28 Jul 2016 01:11:27 +0100 From: Salah Triki To: Luis de Bethencourt Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, viro@zeniv.linux.org.uk, hannes@cmpxchg.org, vdavydov@virtuozzo.com Subject: Re: [PATCH 2/3] befs: remove constant variable Message-ID: <20160728001127.GD3942@pc> References: <1467331652-850-1-git-send-email-luisbg@osg.samsung.com> <1467331652-850-2-git-send-email-luisbg@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467331652-850-2-git-send-email-luisbg@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 01, 2016 at 01:07:31AM +0100, Luis de Bethencourt wrote: > Use macro directly instead of via assigning it to an unchanging variable. > > Signed-off-by: Luis de Bethencourt > --- > fs/befs/linuxvfs.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c > index 6740b0d..a16421a 100644 > --- a/fs/befs/linuxvfs.c > +++ b/fs/befs/linuxvfs.c > @@ -211,7 +211,6 @@ befs_readdir(struct file *file, struct dir_context *ctx) > befs_off_t value; > int result; > size_t keysize; > - unsigned char d_type; > char keybuf[BEFS_NAME_LEN + 1]; > > befs_debug(sb, "---> %s name %pD, inode %ld, ctx->pos %lld", > @@ -236,8 +235,6 @@ more: > return 0; > } > > - d_type = DT_UNKNOWN; > - > /* Convert to NLS */ > if (BEFS_SB(sb)->nls) { > char *nlsname; > @@ -249,14 +246,14 @@ more: > return result; > } > if (!dir_emit(ctx, nlsname, nlsnamelen, > - (ino_t) value, d_type)) { > + (ino_t) value, DT_UNKNOWN)) { > kfree(nlsname); > return 0; > } > kfree(nlsname); > } else { > if (!dir_emit(ctx, keybuf, keysize, > - (ino_t) value, d_type)) > + (ino_t) value, DT_UNKNOWN)) > return 0; > } > ctx->pos++; > -- > 2.5.1 > Acked-by: Salah Triki Thanx :) salah