From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Bob Liu <bob.liu@oracle.com>
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
roger.pau@citrix.com
Subject: Re: [PATCH 1/3] xen-blkfront: fix places not updated after introducing 64KB page granularity
Date: Wed, 27 Jul 2016 21:19:42 -0400 [thread overview]
Message-ID: <20160728011942.GB3165@char.us.oracle.com> (raw)
In-Reply-To: <1469510377-15131-1-git-send-email-bob.liu@oracle.com>
On Tue, Jul 26, 2016 at 01:19:35PM +0800, Bob Liu wrote:
> Two places didn't get updated when 64KB page granularity was introduced, this
> patch fix them.
>
> Signed-off-by: Bob Liu <bob.liu@oracle.com>
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Could you rebase this on xen-tip/for-linus-4.8 pls?
> ---
> drivers/block/xen-blkfront.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> index fcc5b4e..032fc94 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -1321,7 +1321,7 @@ free_shadow:
> rinfo->ring_ref[i] = GRANT_INVALID_REF;
> }
> }
> - free_pages((unsigned long)rinfo->ring.sring, get_order(info->nr_ring_pages * PAGE_SIZE));
> + free_pages((unsigned long)rinfo->ring.sring, get_order(info->nr_ring_pages * XEN_PAGE_SIZE));
> rinfo->ring.sring = NULL;
>
> if (rinfo->irq)
> @@ -2013,7 +2013,7 @@ static int blkif_recover(struct blkfront_info *info)
>
> blkfront_gather_backend_features(info);
> segs = info->max_indirect_segments ? : BLKIF_MAX_SEGMENTS_PER_REQUEST;
> - blk_queue_max_segments(info->rq, segs);
> + blk_queue_max_segments(info->rq, segs / GRANTS_PER_PSEG);
>
> for (r_index = 0; r_index < info->nr_rings; r_index++) {
> struct blkfront_ring_info *rinfo = &info->rinfo[r_index];
> --
> 1.7.10.4
>
next prev parent reply other threads:[~2016-07-28 1:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 5:19 [PATCH 1/3] xen-blkfront: fix places not updated after introducing 64KB page granularity Bob Liu
2016-07-26 5:19 ` [PATCH v2 2/3] xen-blkfront: introduce blkif_set_queue_limits() Bob Liu
2016-07-27 10:48 ` Roger Pau Monné
2016-07-26 5:19 ` [PATCH v2 3/3] xen-blkfront: dynamic configuration of per-vbd resources Bob Liu
2016-07-26 8:44 ` Roger Pau Monné
2016-07-26 8:58 ` Bob Liu
2016-07-26 15:48 ` Roger Pau Monné
2016-07-28 1:19 ` Konrad Rzeszutek Wilk [this message]
2016-07-28 9:03 ` [PATCH 1/3] xen-blkfront: fix places not updated after introducing 64KB page granularity Bob Liu
-- strict thread matches above, loose matches on Subject: below --
2016-07-15 9:31 Bob Liu
2016-07-21 8:06 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160728011942.GB3165@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=bob.liu@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).