From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758908AbcG1BT6 (ORCPT ); Wed, 27 Jul 2016 21:19:58 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:22389 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751229AbcG1BTw convert rfc822-to-8bit (ORCPT ); Wed, 27 Jul 2016 21:19:52 -0400 Date: Wed, 27 Jul 2016 21:19:42 -0400 From: Konrad Rzeszutek Wilk To: Bob Liu Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, roger.pau@citrix.com Subject: Re: [PATCH 1/3] xen-blkfront: fix places not updated after introducing 64KB page granularity Message-ID: <20160728011942.GB3165@char.us.oracle.com> References: <1469510377-15131-1-git-send-email-bob.liu@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1469510377-15131-1-git-send-email-bob.liu@oracle.com> User-Agent: Mutt/1.6.2 (2016-07-01) Content-Transfer-Encoding: 8BIT X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 26, 2016 at 01:19:35PM +0800, Bob Liu wrote: > Two places didn't get updated when 64KB page granularity was introduced, this > patch fix them. > > Signed-off-by: Bob Liu > Acked-by: Roger Pau Monné Could you rebase this on xen-tip/for-linus-4.8 pls? > --- > drivers/block/xen-blkfront.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c > index fcc5b4e..032fc94 100644 > --- a/drivers/block/xen-blkfront.c > +++ b/drivers/block/xen-blkfront.c > @@ -1321,7 +1321,7 @@ free_shadow: > rinfo->ring_ref[i] = GRANT_INVALID_REF; > } > } > - free_pages((unsigned long)rinfo->ring.sring, get_order(info->nr_ring_pages * PAGE_SIZE)); > + free_pages((unsigned long)rinfo->ring.sring, get_order(info->nr_ring_pages * XEN_PAGE_SIZE)); > rinfo->ring.sring = NULL; > > if (rinfo->irq) > @@ -2013,7 +2013,7 @@ static int blkif_recover(struct blkfront_info *info) > > blkfront_gather_backend_features(info); > segs = info->max_indirect_segments ? : BLKIF_MAX_SEGMENTS_PER_REQUEST; > - blk_queue_max_segments(info->rq, segs); > + blk_queue_max_segments(info->rq, segs / GRANTS_PER_PSEG); > > for (r_index = 0; r_index < info->nr_rings; r_index++) { > struct blkfront_ring_info *rinfo = &info->rinfo[r_index]; > -- > 1.7.10.4 >