Re: [PATCH] Input - elantech: fix debug dump of the current packet

Joe Perches
2016-07-28T18:31:04Z

On Thu, 2016-07-28 at 11:58 +0200, Benjamin Tissoires wrote:
> The use of mixed psmouse_printk() and printk creates 2 lines in the log,
> while the use of %*ph solves everything.
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
>  drivers/input/mouse/elantech.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
> index 615d23e..3461d04 100644
> --- a/drivers/input/mouse/elantech.c
> +++ b/drivers/input/mouse/elantech.c
> @@ -222,12 +222,8 @@ static int elantech_write_reg(struct psmouse *psmouse, unsigned char reg,
>   */
>  static void elantech_packet_dump(struct psmouse *psmouse)
>  {
> - int i;
> -
> - psmouse_printk(KERN_DEBUG, psmouse, "PS/2 packet [");
> - for (i = 0; i < psmouse->pktsize; i++)
> - printk("%s0x%02x ", i ? ", " : " ", psmouse->packet[i]);
> - printk("]\n");
> + psmouse_printk(KERN_DEBUG, psmouse, "PS/2 packet [%*ph]",
> +        psmouse->pktsize, psmouse->packet);
>  }
>
>  /*

This should add a newline "\n" format termination but
how does the original produce multiple lines of output?

It looks more like psmouse_printk should be removed altogether
and dev_debug should be used instead.