Re: [PATCH v2 5/6] net-PPP: Delete an unnecessary assignment in mppe_alloc()

SF Markus Elfring
2014-12-05T12:44:37Z

>> The data structure element "arc4" was assigned a null pointer by the
>> mppe_alloc() function if a previous function call "crypto_alloc_blkcipher"
>> failed.
>
> crypto_alloc_blkcipher() returns error pointers and not NULL.

That is true.

> This patch creates a bug.

Please explain: How?

Did you notice that the data structure element "arc4" was reset
to a null pointer if a failure was detected for the function
call "crypto_alloc_blkcipher"?

Do you find this specific assignment still necessary for exception
handling in the implementation of mppe_alloc() function?

Regards,
Markus