[PATCH 1/1] ACPI: Deletion of an unnecessary check before the function call "pci_dev_put"

SF Markus Elfring
2014-11-30T10:08:55Z

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 30 Nov 2014 10:59:10 +0100

The pci_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/acpi/ioapic.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/acpi/ioapic.c b/drivers/acpi/ioapic.c
index 9a631a6..35963d3 100644
--- a/drivers/acpi/ioapic.c
+++ b/drivers/acpi/ioapic.c
@@ -185,8 +185,7 @@ exit_disable:
if (dev)
pci_disable_device(dev);
exit_put:
- if (dev)
- pci_dev_put(dev);
+ pci_dev_put(dev);
exit_free:
kfree(ioapic);
exit:
--
2.1.3