[PATCH] tools lib traceevent: Delete an unnecessary check before the function call "free_arg"

SF Markus Elfring
2015-06-25T14:18:17Z

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 25 Jun 2015 16:13:47 +0200

The free_arg() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
tools/lib/traceevent/parse-filter.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c
index 0144b3d..724a3be 100644
--- a/tools/lib/traceevent/parse-filter.c
+++ b/tools/lib/traceevent/parse-filter.c
@@ -1239,8 +1239,7 @@ filter_event(struct event_filter *filter, struct event_format *event,
if (filter_type == NULL)
return PEVENT_ERRNO__MEM_ALLOC_FAILED;

- if (filter_type->filter)
- free_arg(filter_type->filter);
+ free_arg(filter_type->filter);
filter_type->filter = arg;

return 0;
--
2.4.4