Re: [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc()

Dan Carpenter
2014-12-05T13:58:32Z

On Fri, Dec 05, 2014 at 03:23:15PM +0300, Dan Carpenter wrote:
> On Thu, Dec 04, 2014 at 11:20:21PM +0100, SF Markus Elfring wrote:
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Thu, 4 Dec 2014 22:42:30 +0100
> >
> > The data structure element "sha1" was assigned a null pointer by the
> > mppe_alloc() after a function call "crypto_alloc_hash" failed.
>
> This patch is also buggy.

Actually it's ok. I was just confused by the changelog.

Sorry about that, Markus.

regards,
dan carpenter