Re: [PATCH 1/1] kprobes: Deletion of an unnecessary check before the function call "module_put"

SF Markus Elfring
2014-11-19T07:09:04Z

>> index 3995f54..f1e7d45 100644
>> --- a/kernel/kprobes.c
>> +++ b/kernel/kprobes.c
>> @@ -1527,8 +1527,7 @@ int register_kprobe(struct kprobe *p)
>> out:
>> mutex_unlock(&kprobe_mutex);
>>
>> - if (probed_mod)
>> - module_put(probed_mod);
>> + module_put(probed_mod);
>
> This is OK, but I you request a comment line over there so that
> code reader can understand it is safe to pass a NULL pointer to
> module_put().

Do you want that I replace the shown null pointer check by a short
comment which repeats an expectation for the affected function call?

Regards,
Markus