Re: [PATCH resent] ALSA: emu10k1: Deletion of unnecessary checks before three function calls

Takashi Iwai
2014-11-03T14:17:14Z

At Mon, 03 Nov 2014 15:10:40 +0100,
SF Markus Elfring wrote:
>
> > Your patch can't be applied cleanly due to your MUA breaking the
> > lines. Please fix your MUA setup, or use an attachment if it's
> > impossible, and resend the patch.
>
> Thanks for your feedback.
>
> Does this example show a conflict between long comments like
> "snd_emu10k1_ctl_private_free( ... *kctl)" after patch ranges and line length
> limitation for email eventually?

Conflict? It's your MUA that is broken.

> > Also, try to align the subject line with the relevant commits. See
> > "git log sound/pci/emu10k1"
>
> I have attached my update suggestion with a slightly different commit title as
> before. Is this variant acceptable?

So, you couldn't fix your MUA? That's bad for you. Many maintainers
dislike attachments and won't accept such patches.

Couldn't you simply send a patch via git-send-email?

In anyway, I applied the patch now. Thanks.

Takashi