[PATCH 1/1] PowerPC-83xx: Deletion of an unnecessary check before the function call "of_node_put"

SF Markus Elfring
2014-11-22T15:27:17Z

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 22 Nov 2014 16:18:20 +0100

The of_node_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/powerpc/platforms/83xx/usb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/powerpc/platforms/83xx/usb.c b/arch/powerpc/platforms/83xx/usb.c
index 1ad748b..5c31d82 100644
--- a/arch/powerpc/platforms/83xx/usb.c
+++ b/arch/powerpc/platforms/83xx/usb.c
@@ -162,8 +162,7 @@ int mpc831x_usb_cfg(void)

iounmap(immap);

- if (immr_node)
- of_node_put(immr_node);
+ of_node_put(immr_node);

/* Map USB SOC space */
ret = of_address_to_resource(np, 0, &res);
--
2.1.3