Re: [PATCH v2 2/2] staging: rtl8188eu: Better memory clean-up in efuse_phymap_to_logical()

Julia Lawall
2014-11-13T08:44:15Z

> diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/core/rtw_efuse.c
> index 697876b..359f169 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_efuse.c
[...]
> -exit:
> +cleanup2:
> + kfree(eFuseWord);
> +
> +cleanup1:
> kfree(efuseTbl);
>
> - kfree(eFuseWord);
> +exit:
> + ;
> }

You are not using the most recent version of the code. The issue has
already been fixed. Concretely, this part of the function now reads:

exit:
kfree(eFuseWord);

eFuseWord_failed:
kfree(efuseTbl);

julia