From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757874AbcG1UVc (ORCPT ); Thu, 28 Jul 2016 16:21:32 -0400 Received: from down.free-electrons.com ([37.187.137.238]:60886 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757475AbcG1UVa (ORCPT ); Thu, 28 Jul 2016 16:21:30 -0400 Date: Thu, 28 Jul 2016 22:21:18 +0200 From: Maxime Ripard To: Julian Calaby Cc: moinejf@free.fr, Chen-Yu Tsai , "Mailing List, Arm" , "linux-kernel@vger.kernel.org" , linux-sunxi Subject: Re: [linux-sunxi] [PATCH] regulator: axp20x: support AXP813 variant Message-ID: <20160728202118.GI6682@lukather> References: <5799d673.58a51c0a.97cf9.b9c0SMTPIN_ADDED_MISSING@gmr-mx.google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7IgncvKP0CVPV/ZZ" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --7IgncvKP0CVPV/ZZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 28, 2016 at 08:24:41PM +1000, Julian Calaby wrote: > Hi All, >=20 > On Thu, Jul 28, 2016 at 5:28 PM, Jean-Francois Moine wr= ote: > > The X-Powers AXP813 PMIC is close enough to the AXP809 with some > > more outputs. > > > > Signed-off-by: Jean-Francois Moine > > --- > > Documentation/devicetree/bindings/mfd/axp20x.txt | 32 ++++++++- > > drivers/mfd/axp20x-rsb.c | 1 + > > drivers/mfd/axp20x.c | 3 + > > drivers/regulator/axp20x-regulator.c | 82 ++++++++++++++++= +++++++- > > include/linux/mfd/axp20x.h | 38 +++++++++++ > > 5 files changed, 153 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/a= xp20x-regulator.c > > index 6d9ac76..c3287c9 100644 > > --- a/drivers/regulator/axp20x-regulator.c > > +++ b/drivers/regulator/axp20x-regulator.c > > @@ -467,7 +543,8 @@ static int axp20x_regulator_probe(struct platform_d= evice *pdev) > > * name. > > */ > > if ((regulators =3D=3D axp22x_regulators && i =3D=3D AX= P22X_DC1SW) || > > - (regulators =3D=3D axp809_regulators && i =3D=3D AX= P809_DC1SW)) { > > + (regulators =3D=3D axp809_regulators && i =3D=3D AX= P809_DC1SW) || > > + (regulators =3D=3D axp813_regulators && i =3D=3D AX= P813_DC1SW)) { >=20 > Are we getting to the point now where we need some other way to flag > these? Maybe a set of flags per regulator? I'd be inclined to say yes. We can also associate a structure to the compatible, and store a bunch of infos there (like does it have a DC1SW regulator in this case). Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --7IgncvKP0CVPV/ZZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXmmk+AAoJEBx+YmzsjxAgi4sQAMD8qhzLoJusldJKSgzlxNdy XoFqLhNozp1jTzBcAgjirUB9gg8iCZdgAmZrdzSU4zt4eeQiMaHQpRBt+ARDKA9O 5UpfVFjWma/UU675yeY084A8SePGU3mmK5fmJRNE+PJuyUd4hHBlr3PeAPi00UcW 0XWo9IgvnJBYJBkkl6fO7kr+C9m9vTlY2lLsseF5sUVboR+v+WtxdIKsqhRBUG38 uV01XMdFyEFQuGhGoOBoppIZXHXtQ2d2g1+uwZ0CRRZXIZM7ZXv1FE76Uxk6b+Mt g5vt6B9IqcV/vlcY4MZkbXdabet6sTgAjdsN9rvQJA/vXT7Kyy6a68yTXXCURoQo 8gHBg/NyUk6VKl0menj05xUROuR+doVdk83RJqQhKPuMAISe981IcQCv5Hekg7sG 8zUur9afkIIwBT6oHpJc88tQs8p13bKArYzufE0XfBra6U6iRHlYrqowliIqbaJJ 7yBJo1pUS6ArkcshcSKwjqOymIm2UBcaII0ebrA0HQTPznL0MbCcGYmaYW/BEs8A 8nj24DD6jFEJYBPapoFzNlUDDOPzww3+a1bOYrFcIfd4FIbCy3xyq3LYbiROs07Y 5yz0k5g+h+yHUdWJrlEi4TY41vVsZheedYceIqKTNJXP92Vxgy3TKdXMZOv+K2SU 7VaBnAT+Azg8BQzBy8ve =F2ok -----END PGP SIGNATURE----- --7IgncvKP0CVPV/ZZ--