From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751924AbcG1WtZ (ORCPT ); Thu, 28 Jul 2016 18:49:25 -0400 Received: from down.free-electrons.com ([37.187.137.238]:35103 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751377AbcG1WtX (ORCPT ); Thu, 28 Jul 2016 18:49:23 -0400 Date: Fri, 29 Jul 2016 00:49:21 +0200 From: Alexandre Belloni To: Dmitry Torokhov Cc: Jonathan Cameron , linux-input@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] input: add ADC resistor ladder driver Message-ID: <20160728224921.GF1494@piout.net> References: <1468352186-14190-1-git-send-email-alexandre.belloni@free-electrons.com> <1468352186-14190-2-git-send-email-alexandre.belloni@free-electrons.com> <20160713004150.GB24789@dtor-ws> <20160728220918.GA25461@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160728220918.GA25461@dtor-ws> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/07/2016 at 15:09:18 -0700, Dmitry Torokhov wrote : > On Tue, Jul 12, 2016 at 05:41:50PM -0700, Dmitry Torokhov wrote: > > Hi Alexandre, > > > > On Tue, Jul 12, 2016 at 09:36:26PM +0200, Alexandre Belloni wrote: > > > A common way of multiplexing buttons on a single input in cheap devices is > > > to use a resistor ladder on an ADC. This driver supports that configuration > > > by polling an ADC channel provided by IIO. > > > > This looks quite reasonable, just a few small comments. > > Ping. > > Did the version below work for you? I am trying sweep in the brand new > drivers before we close merge window. > I was thinking it was too late for 4.8. I've juste tested and it works fine. However, I just sent v5 including the exact same changes but changing mvolt to millivolt as that seemed preferred by Rob. Both versions haver been tested and are fine for me. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com