From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750910AbcG3EwO (ORCPT ); Sat, 30 Jul 2016 00:52:14 -0400 Received: from mail-pf0-f172.google.com ([209.85.192.172]:32924 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750743AbcG3EwG (ORCPT ); Sat, 30 Jul 2016 00:52:06 -0400 Date: Fri, 29 Jul 2016 21:52:01 -0700 From: Bjorn Andersson To: John Stultz , linus.walleij@linaro.org Cc: Jon Hunter , Marc Zyngier , Thomas Gleixner , lkml Subject: Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons Message-ID: <20160730045201.GB13516@tuxbot> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 29 Jul 21:39 PDT 2016, John Stultz wrote: > Hey Jon, > So after rebasing my nexus7 patch stack onto pre-4.8-rc1 tree, I > noticed the power/volume buttons stopped working. > +Linus, as that's gpio-keys on top of two fairly standard gpio/pinctrl drivers (8064 TLMM and SSBI). Regards, Bjorn > I did a manual rebased bisection and chased it down to your commit > 1e2a7d78499e ("irqdomain: Don't set type when mapping an IRQ"). > > Reverting that patch makes things work again, so I wanted to see if > there was any debugging info I could provide to try to help narrow > down the problem here. (Sorry, I'd tinker myself with it some and try > to debug the issue, but after burning my friday night on this, I'm > eager to get away from the keyboard for the weekend). > > thanks > -john