From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753741AbcGaMNB (ORCPT ); Sun, 31 Jul 2016 08:13:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10216 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753672AbcGaMMy (ORCPT ); Sun, 31 Jul 2016 08:12:54 -0400 Date: Sun, 31 Jul 2016 14:02:19 +0200 From: Jiri Olsa To: Mathieu Poirier Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V3 3/6] perf tools: add infrastructure for PMU specific configuration Message-ID: <20160731120219.GA12673@krava> References: <1469742143-22245-1-git-send-email-mathieu.poirier@linaro.org> <1469742143-22245-4-git-send-email-mathieu.poirier@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1469742143-22245-4-git-send-email-mathieu.poirier@linaro.org> User-Agent: Mutt/1.6.2 (2016-07-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Sun, 31 Jul 2016 12:02:22 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 28, 2016 at 03:42:20PM -0600, Mathieu Poirier wrote: > This patch adds PMU driver specific configuration to the parser > infrastructure by preceding any term with the '@' letter. As such > doing something like: > > perf record -e some_event/@cfg1,@cfg2=config/ ... > > will see 'cfg1' and 'cfg2=config' being added to the list of evsel config > terms. Token 'cfg1' and 'cfg2=config' are not processed in user space > and are meant to be interpreted by the PMU driver. > > First the lexer/parser are supplemented with the required definitions to > recognise the driver specific configuration. From there they are simply > added to the list of event terms. The bulk of the work is done in > function "parse_events_add_pmu()" where driver config event terms are > added to a new list of driver config terms, which in turn spliced with > the event's new driver configuration list. > > Signed-off-by: Mathieu Poirier Acked-by: Jiri Olsa thanks, jirka