Re: [PATCH V3 1/6] perf/core: Adding PMU driver specific configuration

Vince Weaver
2016-08-11T03:25:44Z

On Wed, 10 Aug 2016, Mathieu Poirier wrote:
>
> After a little bit of digging around I understand that manpages have
> to be written _after_ the new ioctl call has been added - at least
> that's what I deduce when looking at what Vince Weaver did for the BPF
> support:

The manpage patch doesn't get applied until a feature hits a release
kernel (because sometimes features are backed out at the last minute).

It is good to have a manpage update ready at the time of your initial
patch submission though for a variety of reasons

1. It helps the patch reviewers see what ABI change is being proposed
2. It is better to catch mistakes in the ABI early rather than trying
to fix them after it's hit a released kernel and it's too late
3. By the time the kernel is released, you might have forgotten details
about the change, or moved on to other things, and then it's up
to me to try to figure out the purpose of the change and
unfortunately this isn't always obvious from the git commit logs.

Vince