Re: [PATCH V3 1/6] perf/core: Adding PMU driver specific configuration

Peter Zijlstra
2016-08-05T15:53:50Z

On Fri, Aug 05, 2016 at 09:35:05AM -0600, Mathieu Poirier wrote:
> On 4 August 2016 at 10:58, Peter Zijlstra <peterz@infradead.org> wrote:
> > On Thu, Jul 28, 2016 at 03:42:18PM -0600, Mathieu Poirier wrote:
> >> This patch somewhat mimics the work done on address filters to
> >> add the infrastructure needed to pass PMU specific HW
> >> configuration to the driver before a session starts.
> >>
> >> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> >
> >> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
> >> index c66a485a24ac..90fbc5fd3925 100644
> >> --- a/include/uapi/linux/perf_event.h
> >> +++ b/include/uapi/linux/perf_event.h
> >> @@ -407,6 +407,7 @@ struct perf_event_attr {
> >> #define PERF_EVENT_IOC_ID _IOR('$', 7, __u64 *)
> >> #define PERF_EVENT_IOC_SET_BPF _IOW('$', 8, __u32)
> >> #define PERF_EVENT_IOC_PAUSE_OUTPUT _IOW('$', 9, __u32)
> >> +#define PERF_EVENT_IOC_SET_DRV_CONFIGS _IOW('$', 10, char *)
> >
> > Please also do a manpages patch.
>
> Patch 3/6 in this set documents the new option
> (tools/perf/Documentation/perf-record.tx). Is this what you were
> looking for? If not please expand on the information you want to see
> added add and where.

Since you add an IOCTL (with preferably more structure than present in
this patch, see the other email) this needs to be documented in the
syscall manpage.