Re: [PATCH] clocksource: mips-gic-timer: make gic_clocksource_of_init return int

Daniel Lezcano
2016-08-16T13:57:35Z

On 08/01/2016 05:35 AM, Paul Gortmaker wrote:
> In commit d8152bf85d2c057fc39c3e20a4d623f524d9f09c:
> ("clocksource/drivers/mips-gic-timer: Convert init function to return error")
>
> several return values were added to a void function resulting in:
>
> clocksource/mips-gic-timer.c: In function 'gic_clocksource_of_init':
> clocksource/mips-gic-timer.c:175:3: warning: 'return' with a value, in function returning void [enabled by default]
> clocksource/mips-gic-timer.c:183:4: warning: 'return' with a value, in function returning void [enabled by default]
> clocksource/mips-gic-timer.c:190:3: warning: 'return' with a value, in function returning void [enabled by default]
> clocksource/mips-gic-timer.c:195:3: warning: 'return' with a value, in function returning void [enabled by default]
> clocksource/mips-gic-timer.c:200:3: warning: 'return' with a value, in function returning void [enabled by default]
> clocksource/mips-gic-timer.c:211:2: warning: 'return' with a value, in function returning void [enabled by default]
> clocksource/mips-gic-timer.c: At top level:
> clocksource/mips-gic-timer.c:213:1: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> clocksource/mips-gic-timer.c: In function 'gic_clocksource_of_init':
> clocksource/mips-gic-timer.c:183:18: warning: ignoring return value of 'PTR_ERR', declared with attribute warn_unused_result [-Wunused-result]
>
> Given that the addition of the return values was intentional, it seems
> that the conversion of the containing function from void to int was
> simply overlooked.
>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: linux-mips@linux-mips.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---

Hi Paul,

Thomas is in vacation and I'm returning back.

So I applied this patch as a fix.

Thanks!

-- Daniel

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |