From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755514AbcHBAZo (ORCPT ); Mon, 1 Aug 2016 20:25:44 -0400 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:39444 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755486AbcHBAZl (ORCPT ); Mon, 1 Aug 2016 20:25:41 -0400 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 165.244.98.204 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Tue, 2 Aug 2016 09:11:38 +0900 From: Minchan Kim To: Vladimir Davydov CC: Andrew Morton , Mel Gorman , Hillf Danton , Johannes Weiner , Vlastimil Babka , Michal Hocko , Joonsoo Kim , Rik van Riel , , Subject: Re: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on global reclaim Message-ID: <20160802001138.GB6770@bbox> References: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> MIME-Version: 1.0 In-Reply-To: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB01/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/08/02 09:10:37, Serialize by Router on LGEKRMHUB01/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/08/02 09:10:37, Serialize complete at 2016/08/02 09:10:37 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 01, 2016 at 04:03:10PM +0300, Vladimir Davydov wrote: > We must call shrink_slab() for each memory cgroup on both global and > memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally > changed that so that now shrink_slab() is only called with memcg != NULL > on memcg reclaim. As a result, memcg-aware shrinkers (including > dentry/inode) are never invoked on global reclaim. Fix that. > > Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis") > Signed-off-by: Vladimir Davydov Acked-by: Minchan Kim