From: Al Viro <viro@ZenIV.linux.org.uk>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: v9fs-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 9p: don't use v9fs_parent_fid() when v9fs_fid_clone() is needed
Date: Tue, 2 Aug 2016 01:30:14 +0100 [thread overview]
Message-ID: <20160802003014.GD2356@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1470081437-5008-1-git-send-email-johannes@sipsolutions.net>
On Mon, Aug 01, 2016 at 09:57:17PM +0200, Johannes Berg wrote:
> The introduction of v9fs_parent_fid() broke v9fs_vfs_rename()
> since that doesn't just do v9fs_fid_lookup() but rather uses
> v9fs_fid_clone() on the ->d_parent.
>
> I suppose it'd be possible to introduce v9fs_clone_parent_fid()
> but I decided that just reverting the broken change was better
> for now.
Sorry for the braino; FWIW, I'd rather add
static inline struct p9_fid *fid_clone(struct p9_fid *fid)
{
if (IS_ERR(fid))
return fid;
return p9_client_walk(fid, 0, NULL, 1);
}
and turn those into fid_clone(v9fs_parent_fid(old_dentry)), etc. Has an
extra benefit of simplifying several other places. I'll fix and post
(with credits to you for spotting the bug in question, of course).
next prev parent reply other threads:[~2016-08-02 0:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 19:57 [PATCH] 9p: don't use v9fs_parent_fid() when v9fs_fid_clone() is needed Johannes Berg
2016-08-02 0:30 ` Al Viro [this message]
2016-08-02 5:50 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802003014.GD2356@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox