From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755531AbcHBAaZ (ORCPT <rfc822;w@1wt.eu>);
	Mon, 1 Aug 2016 20:30:25 -0400
Received: from zeniv.linux.org.uk ([195.92.253.2]:41062 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755484AbcHBAaR (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 1 Aug 2016 20:30:17 -0400
Date: Tue, 2 Aug 2016 01:30:14 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: v9fs-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 9p: don't use v9fs_parent_fid() when v9fs_fid_clone() is
 needed
Message-ID: <20160802003014.GD2356@ZenIV.linux.org.uk>
References: <1470081437-5008-1-git-send-email-johannes@sipsolutions.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1470081437-5008-1-git-send-email-johannes@sipsolutions.net>
User-Agent: Mutt/1.6.1 (2016-04-27)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 01, 2016 at 09:57:17PM +0200, Johannes Berg wrote:
> The introduction of v9fs_parent_fid() broke v9fs_vfs_rename()
> since that doesn't just do v9fs_fid_lookup() but rather uses
> v9fs_fid_clone() on the ->d_parent.
> 
> I suppose it'd be possible to introduce v9fs_clone_parent_fid()
> but I decided that just reverting the broken change was better
> for now.

Sorry for the braino; FWIW, I'd rather add

static inline struct p9_fid *fid_clone(struct p9_fid *fid)
{
	if (IS_ERR(fid))
		return fid;
	return p9_client_walk(fid, 0, NULL, 1);
}

and turn those into fid_clone(v9fs_parent_fid(old_dentry)), etc.  Has an
extra benefit of simplifying several other places.  I'll fix and post
(with credits to you for spotting the bug in question, of course).