From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933295AbcHBCjN (ORCPT <rfc822;w@1wt.eu>);
	Mon, 1 Aug 2016 22:39:13 -0400
Received: from mail-pa0-f67.google.com ([209.85.220.67]:32797 "EHLO
	mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933257AbcHBCjC (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 1 Aug 2016 22:39:02 -0400
Date: Tue, 2 Aug 2016 11:19:08 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        lkml <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 1/4] tools lib traceevent: Add install_headers target
Message-ID: <20160802021908.GA25068@danjae.aot.lge.com>
References: <1470073292-18114-1-git-send-email-jolsa@kernel.org>
 <1470073292-18114-2-git-send-email-jolsa@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1470073292-18114-2-git-send-email-jolsa@kernel.org>
User-Agent: Mutt/1.6.2 (2016-07-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jiri,

On Mon, Aug 01, 2016 at 07:41:29PM +0200, Jiri Olsa wrote:
> Adding install_headers target to install all headers
> under 'include/traceevent' path, like:
> 
>   $ make DESTDIR=/tmp/krava prefix=/usr install_headers
>   $ find /tmp/krava/ -type f
>   /tmp/krava/usr/include/traceevent/kbuffer.h
>   /tmp/krava/usr/include/traceevent/event-utils.h
>   /tmp/krava/usr/include/traceevent/event-parse.h
> 
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Link: http://lkml.kernel.org/n/tip-if70lj3zhdc3csdqm5webjvc@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
>  tools/lib/traceevent/Makefile | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile
> index 7851df1490e0..8e44bea646ee 100644
> --- a/tools/lib/traceevent/Makefile
> +++ b/tools/lib/traceevent/Makefile
> @@ -240,7 +240,7 @@ define do_install
>  	if [ ! -d '$(DESTDIR_SQ)$2' ]; then		\
>  		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$2';	\
>  	fi;						\
> -	$(INSTALL) $1 '$(DESTDIR_SQ)$2'
> +	$(INSTALL) $(if $3,-m $3,) $1 '$(DESTDIR_SQ)$2'
>  endef
>  
>  define do_install_plugins
> @@ -264,6 +264,12 @@ install_plugins: $(PLUGINS)
>  	$(call QUIET_INSTALL, trace_plugins) \
>  		$(call do_install_plugins, $(PLUGINS))
>  
> +install_headers:
> +	$(call QUIET_INSTALL, headers) \
> +		$(call do_install,event-parse.h,$(prefix)/include/traceevent,644); \
> +		$(call do_install,event-utils.h,$(prefix)/include/traceevent,644); \
> +		$(call do_install,kbuffer.h,$(prefix)/include/traceevent,644)

For possible future changes, what about making it to use the wildcard
somehow?  Or else, we could define HEADER_FILES variable..

Thanks,
Namhyung


> +
>  install: install_lib
>  
>  clean:
> -- 
> 2.4.11
>