public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Thomas Garnier <thgarnie@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
	Kees Cook <keescook@chromium.org>,
	x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
	kernel-hardening@lists.openwall.com
Subject: Re: [PATCH] x86/mm: Enable KASLR for vmemmap memory region (x86_64)
Date: Tue, 2 Aug 2016 10:14:56 +0200	[thread overview]
Message-ID: <20160802081438.GE9601@gmail.com> (raw)
In-Reply-To: <CAJcbSZHZa0tk29i08xKwRuSA0hSQJ7ec3+-1W3zQ5pibC19v_Q@mail.gmail.com>


* Thomas Garnier <thgarnie@google.com> wrote:

> On Wed, Jul 27, 2016 at 8:59 AM, Thomas Garnier <thgarnie@google.com> wrote:
> > Add vmemmap in the list of randomized memory regions.
> >
> > The vmemmap region holds a representation of the physical memory (through
> > a struct page array). An attacker could use this region to disclose the
> > kernel memory layout (walking the page linked list).
> >
> > Signed-off-by: Thomas Garnier <thgarnie@google.com>
> > Signed-off-by: Kees Cook <keescook@chromium.org>
> > ---
> > Missing patch didn't pick-up by the tip bot on KASLR memory randomization.
> > Resending after rebase on tip and tests as discussed with Ingo.
> > Based on tip 4bcc8cf6ab5932cbb2511c8e18065e61b069f21c
> 
> Ingo: Any comment? Can you integrate it on tip?
> 
> > ---
> >  arch/x86/include/asm/kaslr.h            |  1 +
> >  arch/x86/include/asm/pgtable_64_types.h |  4 +++-
> >  arch/x86/mm/kaslr.c                     | 24 +++++++++++++++++++++++-
> >  3 files changed, 27 insertions(+), 2 deletions(-)

After the merge window is over. There's no bad effect from the lack of this patch, 
other than lower level of randomization of kernel virtual addresses, right?

Thanks,

	Ingo

  reply	other threads:[~2016-08-02  8:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-27 15:59 [PATCH] x86/mm: Enable KASLR for vmemmap memory region (x86_64) Thomas Garnier
2016-08-01 17:09 ` Thomas Garnier
2016-08-02  8:14   ` Ingo Molnar [this message]
2016-08-02 14:24     ` Thomas Garnier
2016-08-10 18:13 ` [tip:x86/mm] x86/mm/64: Enable KASLR for vmemmap memory region tip-bot for Thomas Garnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160802081438.GE9601@gmail.com \
    --to=mingo@kernel.org \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=thgarnie@google.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox