From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753327AbcHBJdF (ORCPT ); Tue, 2 Aug 2016 05:33:05 -0400 Received: from outbound-smtp02.blacknight.com ([81.17.249.8]:33788 "EHLO outbound-smtp02.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751938AbcHBJci (ORCPT ); Tue, 2 Aug 2016 05:32:38 -0400 Date: Tue, 2 Aug 2016 10:32:08 +0100 From: Mel Gorman To: Vladimir Davydov Cc: Andrew Morton , Hillf Danton , Johannes Weiner , Vlastimil Babka , Michal Hocko , Joonsoo Kim , Minchan Kim , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on global reclaim Message-ID: <20160802093208.GH2799@techsingularity.net> References: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 01, 2016 at 04:03:10PM +0300, Vladimir Davydov wrote: > We must call shrink_slab() for each memory cgroup on both global and > memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally > changed that so that now shrink_slab() is only called with memcg != NULL > on memcg reclaim. As a result, memcg-aware shrinkers (including > dentry/inode) are never invoked on global reclaim. Fix that. > > Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis") > Signed-off-by: Vladimir Davydov Acked-by: Mel Gorman -- Mel Gorman SUSE Labs