From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966900AbcHBNuY (ORCPT ); Tue, 2 Aug 2016 09:50:24 -0400 Received: from smtprelay0062.hostedemail.com ([216.40.44.62]:40818 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S966030AbcHBNt5 (ORCPT ); Tue, 2 Aug 2016 09:49:57 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1434:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3871:3872:3874:4184:4605:5007:6119:6120:6261:7875:7903:10004:10400:10848:10967:11026:11232:11657:11658:11914:12043:12296:12517:12519:12740:13439:14180:14181:14659:14721:21060:21080:30046:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: sofa34_6687734dfbd48 X-Filterd-Recvd-Size: 3431 Date: Tue, 2 Aug 2016 09:48:23 -0400 From: Steven Rostedt To: Jiri Olsa Cc: Namhyung Kim , Jiri Olsa , Arnaldo Carvalho de Melo , lkml , David Ahern , Ingo Molnar , Peter Zijlstra Subject: Re: [RFC 0/4] tools lib traceevent: Install fixes Message-ID: <20160802094823.4a58b42f@gandalf.local.home> In-Reply-To: <20160802093134.GB2036@krava> References: <1470073292-18114-1-git-send-email-jolsa@kernel.org> <20160802031055.GB25068@danjae.aot.lge.com> <20160802093134.GB2036@krava> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Aug 2016 11:31:34 +0200 Jiri Olsa wrote: > On Tue, Aug 02, 2016 at 12:10:55PM +0900, Namhyung Kim wrote: > > On Mon, Aug 01, 2016 at 07:41:28PM +0200, Jiri Olsa wrote: > > > hi, > > > sending traceevent changes to make this lib installable > > > under rpm spec. > > > > > > Basically adding support to: > > > - install header files > > > - install version links > > > > > > Having this patchset applied over the fedora source, > > > I could built following rpms: > > > > > > kernel-tools-libs > > > kernel-tools-libs-devel > > > > > > with added libtraceevent stuff: > > > > > > $ rpm -ql kernel-tools-libs > > > /usr/lib64/libcpupower.so.0 > > > /usr/lib64/libcpupower.so.0.0.0 > > > /usr/lib64/libtraceevent.so.1 > > > /usr/lib64/libtraceevent.so.1.1.0 > > > > > > $ rpm -ql kernel-tools-libs-devel > > > /usr/include/cpufreq.h > > > /usr/include/traceevent > > > /usr/include/traceevent/event-parse.h > > > /usr/include/traceevent/event-utils.h > > > /usr/include/traceevent/kbuffer.h > > > /usr/lib64/libcpupower.so > > > /usr/lib64/libtraceevent.a > > > /usr/lib64/libtraceevent.so > > > > > > and could build following ex.c outside the kernel tree: > > > > > > $ cat ex.c > > > #include > > > > > > int main(void) > > > { > > > struct pevent *pevent = pevent_alloc(); > > > printf("krava %p\n", pevent); > > > return 0; > > > } > > > $ gcc -o ex ex.c -ltraceevent -ldl > > > $ ./ex > > > krava 0x10c6010 > > > $ > > > > On my system, building ex.c with libtraceevent failed: > > > > $ gcc -I ~/.local/include/ ex.c -L ~/.local/lib64 -ltraceevent -ldl > > /home/namhyung/.local/lib64/libtraceevent.so: undefined reference to `str_error_r' > > collect2: error: ld returned 1 exit status > > > > > > Also I think it'd be better for libtraceevent has dependency to libdl > > explicitly so that we can get rid of -ldl at the end. > > agreed, I'll queue your patch if v2 is needed > BTW, before we start making this ready for their own libraries, I'd like to make some changes with the naming convention. Mainly with event_format and format_field. Perhaps we should change them to pevent_event and pevent_field? -- Steve