From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753615AbcHBKmg (ORCPT ); Tue, 2 Aug 2016 06:42:36 -0400 Received: from muru.com ([72.249.23.125]:44934 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752121AbcHBKm2 (ORCPT ); Tue, 2 Aug 2016 06:42:28 -0400 Date: Tue, 2 Aug 2016 03:33:34 -0700 From: Tony Lindgren To: Andreas Kemnade Cc: Bin Liu , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org Subject: Re: [PATCH] musb: omap2430: do not assume balanced enable()/disable() Message-ID: <20160802103334.GC28140@atomide.com> References: <1469814151-2571-1-git-send-email-andreas@kemnade.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1469814151-2571-1-git-send-email-andreas@kemnade.info> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Andreas Kemnade [160729 11:14]: > The code assumes that omap2430_musb_enable() and > omap2430_musb_disable() is called in a balanced way. The > That fact is broken by the fact that musb_init_controller() calls > musb_platform_disable() to switch from unknown state to off state. OK, some spelling issues with the above paragraph though :) > That means that phy_power_off() is called first so that > phy->power_count gets -1 and the phy is not enabled on phy_power_on(). > In the probably common case of using the phy_twl4030, that > prevents also charging the battery and so makes further > kernel debugging hard. Is this with v4.7 kernel? Also, care to describe how you hit this and on which hardware? Just wondering.. > The patch prevents phy_power_off() from being called when > it is already off. OK Regards, Tony