From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755900AbcHBLgY (ORCPT ); Tue, 2 Aug 2016 07:36:24 -0400 Received: from mga14.intel.com ([192.55.52.115]:22321 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755678AbcHBLa3 (ORCPT ); Tue, 2 Aug 2016 07:30:29 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1028250987" From: Baole Ni To: linus.walleij@linaro.org, wsa@the-dreams.de, linux@roeck-us.net, airlied@linux.ie, kgene@kernel.org, k.kozlowski@samsung.com, dougthompson@xmission.com, bp@alien8.de Cc: linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, aduggan@synaptics.com, dianders@chromium.org Subject: [PATCH 0244/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:52:46 +0800 Message-Id: <20160802105246.30008-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/i2c/busses/i2c-stu300.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-stu300.c b/drivers/i2c/busses/i2c-stu300.c index 460c134..8128e25 100644 --- a/drivers/i2c/busses/i2c-stu300.c +++ b/drivers/i2c/busses/i2c-stu300.c @@ -133,7 +133,7 @@ enum stu300_error { /* I2C clock speed, in Hz 0-400kHz*/ static unsigned int scl_frequency = 100000; -module_param(scl_frequency, uint, 0644); +module_param(scl_frequency, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); /** * struct stu300_dev - the stu300 driver state holder -- 2.9.2